Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added endpoint to delete a company and its offers #178

Merged
merged 2 commits into from
Sep 5, 2021
Merged

Added endpoint to delete a company and its offers #178

merged 2 commits into from
Sep 5, 2021

Conversation

BrunoRosendo
Copy link
Member

closes #140

BrunoRosendo
BrunoRosendo commented Aug 22, 2021
View reviewed changes
Copy link
Member Author

@BrunoRosendo BrunoRosendo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finish but I needed your feedback on a couple of subjects. @imnotteixeira @DoStini Maybe?

@BrunoRosendo BrunoRosendo force-pushed the feature/deleteCompanies branch from 92d9677 to bc01f7e Compare August 23, 2021 14:57
@BrunoRosendo
Copy link
Member Author

The feature should be done, it's just missing the tests but I'll do them later

@imnotteixeira imnotteixeira added this to the MVP milestone Aug 23, 2021
@BrunoRosendo BrunoRosendo force-pushed the feature/deleteCompanies branch 2 times, most recently from 825e333 to 59f524a Compare September 3, 2021 16:55
BrunoRosendo
BrunoRosendo commented Sep 3, 2021
View reviewed changes
BrunoRosendo
BrunoRosendo commented Sep 3, 2021
View reviewed changes
@BrunoRosendo
Copy link
Member Author

I also ran npm audit fix since the CI audit was failing

@BrunoRosendo BrunoRosendo marked this pull request as ready for review September 3, 2021 16:57
imnotteixeira
imnotteixeira requested changes Sep 4, 2021
View reviewed changes
@imnotteixeira imnotteixeira mentioned this pull request Sep 4, 2021
Open
@imnotteixeira
Copy link
Collaborator

As mentioned in the informational email, this is a permanent and destructive action. As such, we should have a way of confirming deletion via email before actually deleting it. I'm creating an issue to track that feature afterwards (#184).

@BrunoRosendo BrunoRosendo force-pushed the feature/deleteCompanies branch from 59f524a to 54bfadc Compare September 5, 2021 00:14
@BrunoRosendo BrunoRosendo merged commit 48b0e9c into develop Sep 5, 2021
@BrunoRosendo BrunoRosendo deleted the feature/deleteCompanies branch September 5, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotteixeira imnotteixeira imnotteixeira approved these changes

@DoStini DoStini Awaiting requested review from DoStini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Allow Companies to delete their account
2 participants
@BrunoRosendo @imnotteixeira