Make jobMinDuration and jobMaxDuration required #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naapperas
changed the title
Naapperas
requested changes
Dec 7, 2022
marco-vb
force-pushed
the
fix/make-job-durations-required
branch
3 times, most recently
from
8da60c4 to
6bc287e
Compare
Codecov ReportBase: 90.50% // Head: 90.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #278 +/- ##
===========================================
- Coverage 90.50% 90.46% -0.05%
===========================================
Files 54 54
Lines 1401 1395 -6
Branches 223 222 -1
===========================================
- Hits 1268 1262 -6
Misses 129 129
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Naapperas
previously approved these changes
Dec 15, 2022
BrunoRosendo
requested changes
Dec 18, 2022
There was a problem hiding this comment.
@marco-vb Please update the API documentation with this change. It is stored under docs/ and the syntax resembles markdown, you can read the docs (in the README) to know how to use it.
marco-vb
force-pushed
the
fix/make-job-durations-required
branch
from
f0d056a to
afcc52e
Compare
Naapperas
requested changes
Dec 23, 2022
marco-vb
force-pushed
the
fix/make-job-durations-required
branch
from
afcc52e to
a18f5c1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263