Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Search funcionality to GET /offers #99

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

imnotteixeira
Copy link
Collaborator

@imnotteixeira imnotteixeira commented Dec 29, 2020

Closes #55
Closes #11

Added search functionality (at least an initial version)

It supports:

  • Full-text search (via the value param which is open text) (uses the title, jobType, location, fields and technologies for the search, after Add owner auto-fill when creating offers #94, we can implement company name search as well)
  • Results filtering on the following fields:

@imnotteixeira imnotteixeira self-assigned this Dec 29, 2020
@imnotteixeira imnotteixeira added this to the MVP milestone Dec 29, 2020
@imnotteixeira imnotteixeira force-pushed the feature/offers-search branch 3 times, most recently from c7b4059 to c5c383d Compare January 4, 2021 21:25
@miguelpduarte
Copy link
Collaborator

Given that #94 was already merged, does this include company name in the FTS?

@imnotteixeira
Copy link
Collaborator Author

Given that #94 was already merged, does this include company name in the FTS?

Yes, check the latest commit

Copy link
Collaborator

@miguelpduarte miguelpduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small changes, almost good to go. The end-to-end tests look pretty cool btw! 😎

src/models/constants/JobTypes.js Show resolved Hide resolved
test/company_schema.js Outdated Show resolved Hide resolved
test/company_schema.js Outdated Show resolved Hide resolved
@imnotteixeira imnotteixeira force-pushed the feature/offers-search branch from d30c03c to 7d7b3ef Compare January 8, 2021 23:11
@imnotteixeira imnotteixeira force-pushed the feature/offers-search branch from 7d7b3ef to 627e8b1 Compare January 8, 2021 23:12
@imnotteixeira imnotteixeira merged commit 083a142 into develop Jan 11, 2021
@imnotteixeira imnotteixeira deleted the feature/offers-search branch January 11, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer Search Filtering Implement post searching
2 participants