Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate company application page #309

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

FranciscoCardoso913
Copy link
Contributor

@FranciscoCardoso913 FranciscoCardoso913 commented Feb 11, 2023

Important:

This is a backend issue! See the original issue and the changes made in the backend here: NIAEFEUP/nijobs-be#306

Discussed solution:

-When created, applications should have a state UNVERIFIED by default instead of the current PENDING state;

-After creating an application an email with a link should be sent to the company so they can validate their application, the link should expire in 10 minutes;

-A company should not be able to create an application with an email associated with an UNVERIFIED application whose link is yet to expire;

-If the link of an application expires and the company tries to create another application the previous application of that company should be deleted;

-The link should send the user to a page where the application is validated, when validating the application its state should change to pending and an email should be sent to the company.

Front-End changes:

-You can now search for unverified applications;

Screenshot from 2023-02-11 20-18-26

-The message which appeared after creating an application has now changed to indicate the company they have to validate their application;

Screenshot from 2023-02-11 20-14-37

-New error message when trying to create a new application with an email associated with an UNVERIFIED application whose link is yet to expire;

Screenshot from 2023-02-11 20-34-35

-Created a new page for validating the company, the page displays various messages indicating if the validation was successful or if an error has occurred;

States of the new page:

-Page when loading:

Screenshot from 2023-02-11 20-22-53

-Page when everything goes well:

Screenshot from 2023-02-11 20-25-06

 -Page when the application was already validated:

Screenshot from 2023-02-11 20-30-44

-Page when the application does not exist(the token in the link is incorret):

Screenshot from 2023-02-11 20-27-41

-Page when the link has expired:

Screenshot from 2023-02-11 20-26-34

-Page when an unexpected error occurs:

Screenshot from 2023-02-11 20-28-51

What is yet to be done:

 -Tests;

 -Google analytics;

Doubts:

-The error messages used have a style made by us, however, there already exists a template style to display errors ( a component called ErrorComponent), should we use that or keep it as it is?

-Should we change any of the designs of the validation page?

-Should we change any of the texts?	

-Is everything in the correct place or is there anything that is more adequate somewhere else?

src/components/Apply/Company/CompanyApplicationUtils.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/pages/ValidationPage.js Outdated Show resolved Hide resolved
src/AppRouter.js Outdated Show resolved Hide resolved
@FranciscoCardoso913
Copy link
Contributor Author

Important

The workflow regarding this issue has been changed
You can check it here: NIAEFEUP/nijobs-be#306 (comment)

@FranciscoCardoso913 FranciscoCardoso913 force-pushed the validate-company-application-Page branch from 42cab26 to aa0ac75 Compare March 11, 2023 12:31
@Naapperas
Copy link
Member

@FranciscoCardoso913 @dsantosferreira any progress on this?

@dsantosferreira
Copy link
Contributor

We have our first version of the warnings shown to users whose accounts aren't yet verified in the "Create an offer" and "My offers" pages. Feel free to share your opinions!

warning1
warning2

@BrunoRosendo
Copy link
Member

We have our first version of the warnings shown to users whose accounts aren't yet verified in the "Create an offer" and "My offers" pages. Feel free to share your opinions!

warning1 warning2

I like how it turned out! I just have some doubts about the icon. Is it also from material UI? The style seems a bit off from the rest of your icons, is it imported from @material-ui/icons or somewhere else?

Assuming it is the right one, I guess it's the one on the right. Do you mind trying out the first one and see how it looks like?
image

@dsantosferreira
Copy link
Contributor

The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred.
Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!

image

@Naapperas
Copy link
Member

The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!

image

Honestly, I prefer the filed version of the icon.

@BrunoRosendo
Copy link
Member

The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!

image

I do think the filled version looks more like the remaining icons we use (from what I recall, but feel free to check it out)

Copy link
Member

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the console.log statements

@FranciscoCardoso913 FranciscoCardoso913 force-pushed the validate-company-application-Page branch from 16e11d1 to 3337414 Compare August 29, 2023 15:52
@FranciscoCardoso913 FranciscoCardoso913 force-pushed the validate-company-application-Page branch from 3337414 to 3c5b58f Compare August 29, 2023 16:08
…cation services

Making tests for the validate application and the fetch company application services
@FranciscoCardoso913 FranciscoCardoso913 force-pushed the validate-company-application-Page branch 2 times, most recently from 055fe5a to 0274047 Compare September 16, 2023 17:31
@FranciscoCardoso913 FranciscoCardoso913 force-pushed the validate-company-application-Page branch from 0274047 to decd155 Compare September 16, 2023 17:52
@FranciscoCardoso913 FranciscoCardoso913 force-pushed the validate-company-application-Page branch from 5f0cc3d to 23032fa Compare September 16, 2023 19:22
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 94.84% and project coverage change: +0.52% 🎉

Comparison is base (0cab005) 89.19% compared to head (23032fa) 89.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
+ Coverage    89.19%   89.71%   +0.52%     
===========================================
  Files          177      180       +3     
  Lines         3434     3530      +96     
  Branches       866      890      +24     
===========================================
+ Hits          3063     3167     +104     
+ Misses         371      363       -8     
Files Changed Coverage Δ
...omponents/Apply/Company/ApplicationConfirmation.js 100.00% <ø> (ø)
...ponents/Offers/Form/form-components/offerStyles.js 100.00% <ø> (ø)
src/components/Offers/New/CreateOfferForm.js 24.00% <ø> (ø)
...view/Applications/ApplicationsReviewTableSchema.js 100.00% <ø> (ø)
src/utils/analytics/constants.js 100.00% <ø> (ø)
...omponents/Apply/Company/CompanyApplicationUtils.js 83.33% <75.00%> (-16.67%) ⬇️
src/pages/CompanyOffersManagementPage.js 88.88% <83.33%> (+55.55%) ⬆️
src/components/utils/Alert.js 85.71% <85.71%> (ø)
...omponents/Offers/Form/form-components/OfferForm.js 96.77% <100.00%> (+0.85%) ⬆️
src/pages/ValidationPage.js 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants