-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port analytics to GA4 #318
Conversation
5131e9c
to
c6dd43c
Compare
Data is already flowing to the new property in GA4. It'll also continue flowing to GA3 until 1st of July. GA4 has a complete new interface and data flow but Google makes the transition easier by automatically translating old mechanisms to the new ones. GA4 is IMO simpler than GA3, everything is based on events and event parameters. This means we can still use the old API (e.g. dimensions and old event system) and they'll all be converted into events and event parameters. This also means our code isn't very clear when compared to the new dashboard. I think we can change that later since porting over is what's mostly important right now. Additionally, since the dashboard is brand new, we should also setup reports and charts in the new properties, which can be done in the staging property after merging to dev. GA4 offers more flexibility and less OOTB reports, so we need to generate our own. I will be pushing the final version (code barely changes) in a while and asking for review |
I've yet to successfully generate charts using our previous custom dimensions but it should be possible, by the documentation Nevertheless, I created #319 to use the new event system properly |
I also created #320 for the archive |
4964af6
to
f416e71
Compare
f416e71
to
b02eab4
Compare
I found some problems with the events, I need to figure out how to properly set this up to be completely compatible with timings and other events https://www.thyngster.com/performance-timing-tracking-with-google-analytics-4 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #318 +/- ##
========================================
Coverage 89.07% 89.07%
========================================
Files 176 176
Lines 3395 3395
Branches 855 855
========================================
Hits 3024 3024
Misses 371 371
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left just a simple question but it does not need to be fixed.
@Naapperas can you do something about codecov? There is nothing to test on those lines |
closes #230
This PR ports the analytics system from GA3/UA to Google Analytics 4.
This should be currently enough to have it running but I still need to test all the functionalities we had previously. I also want to check which new functionalities we might want to use or change from GA3, since GA4 remade how data is handled.
Since GA4 is completely different from GA3, it doesn't seem to be possible to port data over so we'll have to start recording again from the day we release the new version.
I also created new GA4 properties in NIJobs analytics account but I still need to check for extra configurations