Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exchange #281

Merged
merged 81 commits into from
Dec 30, 2024
Merged

Feature/exchange #281

merged 81 commits into from
Dec 30, 2024

Conversation

tomaspalma
Copy link
Member

@tomaspalma tomaspalma commented Sep 5, 2024

This PR puts the beta version of exchange into develop

The goal of this PR is to integrate features that are already working that are useful for other issues besides exchange. Also, some things about the code structure changed and it is good for them to be merged as soon as possible.

The exchange system is almost ready but there are still details to trim. The goal of this PR is not to fix it.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for tts-fe-preview ready!

Name Link
🔨 Latest commit fa95be2
🔍 Latest deploy log https://app.netlify.com/sites/tts-fe-preview/deploys/6772b04cc3e8780008c31851
😎 Deploy Preview https://deploy-preview-281--tts-fe-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomaspalma tomaspalma force-pushed the feature/exchange branch 4 times, most recently from f177ce6 to 634f30a Compare September 12, 2024 09:52
tomaspalma and others added 13 commits September 13, 2024 18:19
Co-authored-by: pfpo <[email protected]>
Co-authored-by: eduardooliveiraps <[email protected]>
Co-authored-by: joaonevesf <[email protected]>
Co-authored-by: pfpo <[email protected]>
Co-authored-by: eduardooliveiraps <[email protected]>
Co-authored-by: joaonevesf <[email protected]>
Co-authored-by: pfpo <[email protected]>
Co-authored-by: eduardooliveiraps <[email protected]>
Co-authored-by: joaonevesf <[email protected]>
Co-authored-by: pfpo <[email protected]>
Co-authored-by: eduardooliveiraps <[email protected]>
Co-authored-by: joaonevesf <[email protected]>
Co-authored-by: pfpo <[email protected]>
Co-authored-by: eduardooliveiraps <[email protected]>
Co-authored-by: joaonevesf <[email protected]>
Co-authored-by: pfpo <[email protected]>
Co-authored-by: eduardooliveiraps <[email protected]>
Co-authored-by: joaonevesf <[email protected]>
@tomaspalma tomaspalma marked this pull request as ready for review November 30, 2024 00:46
@tomaspalma tomaspalma requested a review from a team December 3, 2024 21:12
Copy link
Contributor

@Wallen-Ribeiro Wallen-Ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine!

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, TTS grows to double of his size, double of his complexity and double of responsibility.
This is a complete new feature with a different purpose of the main already well-defined before. The vision stills the same!
This will enable us to get ride of the "tool" name, become more official and become even more useful to the already public target.

Good Work! 👏

src/App.tsx Show resolved Hide resolved
src/api/services/authService.ts Outdated Show resolved Hide resolved
src/api/services/exchangeRequestService.ts Outdated Show resolved Hide resolved
src/components/auth/HeaderProfileDropdown.tsx Outdated Show resolved Hide resolved
src/components/auth/HeaderProfileDropdown.tsx Show resolved Hide resolved
src/hooks/useSchedule.tsx Show resolved Hide resolved
src/hooks/useSentRequests.tsx Outdated Show resolved Hide resolved
src/hooks/useStudentCourseUnits.tsx Show resolved Hide resolved
src/hooks/useStudentCourseUnits.tsx Outdated Show resolved Hide resolved
Comment on lines +1 to +3
.add-item-button {
@apply bg-white text-black border shadow-md mr-0 hover:bg-gray-50 flex flex-row gap-x-1;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humnn, really? We don't have a button component?

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@tomaspalma tomaspalma merged commit 74d77fc into develop Dec 30, 2024
5 checks passed
@tomaspalma tomaspalma deleted the feature/exchange branch December 30, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants