Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UC classes page redesign #1438

Open
wants to merge 15 commits into
base: ui/redesign
Choose a base branch
from
Open

UC classes page redesign #1438

wants to merge 15 commits into from

Conversation

pedroafmonteiro
Copy link
Contributor

@pedroafmonteiro pedroafmonteiro commented Jan 6, 2025 •
edited
Loading

Closes #1433

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@pedroafmonteiro pedroafmonteiro self-assigned this Jan 6, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 102 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (7d074d2) to head (bfc7b95).
Report is 1 commits behind head on ui/redesign.

Additional details and impacted files 
@@             Coverage Diff             @@
##           ui/redesign   #1438   +/-   ##
===========================================
- Coverage           11%     11%   -0%     
===========================================
  Files              270     271    +1     
  Lines             7358    7415   +57     
===========================================
  Hits               807     807           
- Misses            6551    6608   +57

@pedroafmonteiro
Copy link
Contributor Author

Screen_Recording_20250123_184923.mp4

@pedroafmonteiro pedroafmonteiro marked this pull request as ready for review January 23, 2025 18:51
@pedroafmonteiro pedroafmonteiro requested a review from a team January 23, 2025 18:51
DGoiana
DGoiana reviewed Jan 27, 2025
View reviewed changes
packages/uni_app/lib/view/course_unit_info/widgets/course_unit_classes.dart Outdated
super.initState();
final sessionProvider = context.read<SessionProvider>();
final studentNumber = int.tryParse(
sessionProvider.state!.username.replaceAll(RegExp(r'\D'), ''),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care for the ! operator. Make sure sessionProvider.state is not null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

DGoiana
DGoiana reviewed Jan 27, 2025
View reviewed changes
packages/uni_app/lib/view/course_unit_info/widgets/course_unit_classes.dart
Comment on lines +138 to +140
? lightTheme.textTheme.labelMedium?.copyWith(
color: lightTheme.colorScheme.onPrimary,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the copyWith being used due to an error in the theme?

Copy link
Contributor Author

@pedroafmonteiro pedroafmonteiro Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in figma, both the selected and unselected text are with their typography set to labelMedium, however they are different colors. selected is light/background and unselected is light/gray-middle. In our theme.dart file, labelMedium is set to grayMiddle, so that's why I put the white color there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGoiana DGoiana DGoiana left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@pedroafmonteiro pedroafmonteiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroafmonteiro @DGoiana