Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Map Page #1440

Merged
merged 22 commits into from
Feb 26, 2025
Merged

New Map Page #1440

merged 22 commits into from
Feb 26, 2025

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Jan 8, 2025 •
edited
Loading

Closes #1434


Remaining TODO:

  • Fix search
  • Fix render bugs
  • Expand map to all page
  • pin style
  • Implement additional filters (optional)

@thePeras thePeras changed the base branch from develop to ui/page-layouts January 8, 2025 19:32
Base automatically changed from ui/page-layouts to ui/redesign January 19, 2025 18:12
@thePeras thePeras marked this pull request as ready for review February 6, 2025 12:36
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.04082% with 96 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (dbdf420) to head (283b95a).
Report is 30 commits behind head on ui/redesign.

Additional details and impacted files 
@@             Coverage Diff             @@
##           ui/redesign   #1440   +/-   ##
===========================================
+ Coverage           11%     11%   +1%     
===========================================
  Files              273     269    -4     
  Lines             7821    7780   -41     
===========================================
  Hits               817     817           
+ Misses            7004    6963   -41

vitormpp
vitormpp approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@vitormpp vitormpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thePeras thePeras requested review from DGoiana, Adriano-7 and a team February 26, 2025 09:52
Adriano-7
Adriano-7 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@Adriano-7 Adriano-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there🚀

@thePeras thePeras merged commit 122933e into ui/redesign Feb 26, 2025
6 checks passed
@thePeras thePeras deleted the ui/map-page branch February 26, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adriano-7 Adriano-7 Adriano-7 approved these changes

@vitormpp vitormpp vitormpp approved these changes

@DGoiana DGoiana Awaiting requested review from DGoiana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Map
3 participants
@thePeras @Adriano-7 @vitormpp