Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: Academic Path - Schedule #1445

Open
wants to merge 17 commits into
base: ui/redesign
Choose a base branch
from

Conversation

Granja5
Copy link

@Granja5 Granja5 commented Jan 18, 2025

Closes #1424

Since there are no classes this week, to completely test the schedule page we need to add mock lectures. So, when the page becomes ready to merge we need to delete them first.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@Granja5 Granja5 self-assigned this Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 5.22876% with 145 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (f8a4f55) to head (60307bc).
Report is 10 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff              @@
##           ui/redesign   #1445    +/-   ##
============================================
- Coverage           11%     11%    -0%     
============================================
  Files              270     274     +4     
  Lines             7357    7492   +135     
============================================
+ Hits               807     808     +1     
- Misses            6550    6684   +134     

@Granja5 Granja5 marked this pull request as ready for review January 21, 2025 05:53
@DGoiana
Copy link
Collaborator

DGoiana commented Jan 21, 2025

Care for the use of CardTimeline and the Generic Timeline previously built

…onalities to the general timeline. Slight visual improvements.
@Granja5
Copy link
Author

Granja5 commented Jan 21, 2025

Care for the use of CardTimeline and the Generic Timeline previously built

Now using CardTimeline and the Generic Timeline. Please verify if the changes made to the generic timeline in order to support the same functionalities as the schedule_timeline are correct and can be done without compromising its use for other pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants