Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create academic path courses page #1446

Open
wants to merge 23 commits into
base: ui/redesign
Choose a base branch
from

Conversation

Process-ing
Copy link
Contributor

@Process-ing Process-ing commented Jan 19, 2025

Closes #1430

The base structure of the page is mostly done, but if you see something that needs improvement, let me know.

A few things to note:

  • In the original mockups, each course unit is associated with year of enrollment + year of conclusion. However, it is impossible (from what I know) to know the latter, so I just omitted it from the course selection.
  • The "???" that appears on the course selection is a placeholder for the course abbreviation, since it is currently being fetched as null. It's best to discuss a fix/workaround in the next meeting.
  • The page layout suggests that the course units are only the ones from the selected course. However, it is impossible to associate a curricular unit to a course (Sigarra does not do this association, and can be troublesome for Erasmus students, etc.), so it currently presents all the course units the user is enrolled in.
  • NEW The average bar presents the finished ECTS and total ECTS of the course. The really stupid thing is that the Sigarra API provides the former, but not the latter, so we will also need a workaround for that 💀. Currently, it presents the total of ECTS a student is enrolled in, but that only works for people enrolled in only one course and in their last year.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@Process-ing Process-ing changed the base branch from develop to ui/redesign January 19, 2025 01:33
@Process-ing Process-ing changed the title Create acadepic path courses page Create academic path courses page Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 3.25203% with 119 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (f8a4f55) to head (6107133).
Report is 10 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff              @@
##           ui/redesign   #1446    +/-   ##
============================================
- Coverage           11%     11%    -0%     
============================================
  Files              270     272     +2     
  Lines             7357    7476   +119     
============================================
+ Hits               807     810     +3     
- Misses            6550    6666   +116     

@Process-ing Process-ing marked this pull request as ready for review January 19, 2025 12:35
@Process-ing Process-ing requested a review from a team January 19, 2025 12:50
@Process-ing Process-ing force-pushed the redesign/courses-page branch from cffdb13 to 6e5d5c4 Compare January 20, 2025 13:51
@Process-ing Process-ing force-pushed the redesign/courses-page branch from 6e5d5c4 to b749fb7 Compare January 21, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Academic Path Courses page
1 participant