fix: Added explanation to line and replaced variable

NIAEFEUP · Nov 6, 2024 · 0b5c228 · 0b5c228
1 parent c796bac
commit 0b5c228
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/main/kotlin/pt/up/fe/ni/website/backend/service/upload/CloudinaryFileUploader.kt b/src/main/kotlin/pt/up/fe/ni/website/backend/service/upload/CloudinaryFileUploader.kt
@@ -22,6 +22,7 @@ class CloudinaryFileUploader(private val basePath: String, private val cloudinar
     }
 
     override fun deleteImage(fileName: String) {
+        // Here, fileName is the publicId in Cloudinary, which would be the path to the file
         cloudinary.uploader().destroy(
             fileName,
             null

diff --git a/src/test/kotlin/pt/up/fe/ni/website/backend/controller/EventControllerTest.kt b/src/test/kotlin/pt/up/fe/ni/website/backend/controller/EventControllerTest.kt
@@ -863,17 +863,17 @@ internal class EventControllerTest @Autowired constructor(
 
         @Test
         fun `should fail if event does not exist`() {
-            val unexistentID = 5
+            val nonexistentID = 5
 
-            mockMvc.multipartBuilder("/events/$unexistentID/gallery")
+            mockMvc.multipartBuilder("/events/$nonexistentID/gallery")
                 .asPutMethod()
                 .addFile("image", contentType = MediaType.IMAGE_JPEG_VALUE)
                 .perform()
                 .andExpectAll(
                     status().isNotFound,
                     content().contentType(MediaType.APPLICATION_JSON),
                     jsonPath("$.errors.length()").value(1),
-                    jsonPath("$.errors[0].message").value("activity not found with id $unexistentID")
+                    jsonPath("$.errors[0].message").value("activity not found with id $nonexistentID")
                 )
         }
 
@@ -945,17 +945,17 @@ internal class EventControllerTest @Autowired constructor(
 
         @Test
         fun `should fail if event does not exist`() {
-            val unexistentID = 5
+            val nonexistentID = 5
 
-            mockMvc.multipartBuilder("/events/$unexistentID/gallery")
+            mockMvc.multipartBuilder("/events/$nonexistentID/gallery")
                 .asDeleteMethod()
                 .addPart("imageUrl", mockImageUrl)
                 .perform()
                 .andExpectAll(
                     status().isNotFound,
                     content().contentType(MediaType.APPLICATION_JSON),
                     jsonPath("$.errors.length()").value(1),
-                    jsonPath("$.errors[0].message").value("activity not found with id $unexistentID")
+                    jsonPath("$.errors[0].message").value("activity not found with id $nonexistentID")
                 )
         }