Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FD-1753 -- Loading bug for mappings search #131

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

yelenacox
Copy link
Collaborator

@yelenacox yelenacox commented Nov 4, 2024

The mapping search modal used to display "No results found" while it waited for the results to populate. It now displays a loading spinner.

@yelenacox yelenacox changed the title F FD-1753 -- Loading bug for mappings search Nov 4, 2024
@yelenacox
Copy link
Collaborator Author

Recording.2024-11-04.122634.mp4

Copy link

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yelenacox yelenacox merged commit d9ec0e8 into main Nov 5, 2024
1 check passed
@yelenacox yelenacox deleted the fd-1753/loading-bug branch November 5, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants