Merge pull request #23 from yacchin1205/fix/npm-error

Fix build script for latest JupyterLab
NII-cloud-operation · Nov 12, 2024 · bd76654 · bd76654
2 parents 87c7749 + f37e3e0
commit bd76654
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 72 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -17,29 +17,59 @@ jobs:
       uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
 
     - name: Install dependencies
-      run: python -m pip install -U 'jupyterlab>=4.0.0,<5'
+      run: python -m pip install -U 'jupyterlab>=4.0.0,<5' && python -m pip install -U 'notebook>=7,<8'
 
     - name: Build the extension
       run: |
         set -eux
         jlpm
-        jlpm lint:check
+        jlpm run eslint:check
+        cd ./components
+        npm install
+        npm run build
+        cd ..
+        cd ./nbextension
+        npm install
+        npm run build
+        cd ..
         python -m pip install .
 
         jupyter labextension list 2>&1 | grep -ie "lc_notebook_diff.*OK"
         python -m jupyterlab.browser_check
 
+        jlpm install
+        cd ./ui-tests
+        jlpm install
+        jlpm playwright install
+        jlpm playwright test
+        cd ..
+
         pip install build
         python -m build --sdist
         cp dist/*.tar.gz myextension.tar.gz
         pip uninstall -y "lc_notebook_diff" jupyterlab
         rm -rf myextension
 
-    - uses: actions/upload-artifact@v2
+        npm pack
+        mv lc_notebook_diff-*.tgz myextension-nodejs.tgz
+
+    - uses: actions/upload-artifact@v4
+      if: ${{ !cancelled() }}
+      with:
+        name: playwright-report
+        path: ui-tests/playwright-report/
+        retention-days: 30
+
+    - uses: actions/upload-artifact@v4
       with:
         name: myextension-sdist
         path: myextension.tar.gz
 
+    - uses: actions/upload-artifact@v4
+      with:
+        name: myextension-nodejs
+        path: myextension-nodejs.tgz
+
   test_isolated:
     needs: build
     runs-on: ubuntu-latest
@@ -52,7 +82,7 @@ jobs:
       with:
         python-version: '3.9'
         architecture: 'x64'
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v4
       with:
         name: myextension-sdist
     - name: Install and Test

diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -79,12 +79,19 @@ jobs:
         npm pack
         mv lc_notebook_diff-*.tgz myextension-nodejs.tgz
 
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v4
+      if: ${{ !cancelled() }}
+      with:
+        name: playwright-report
+        path: ui-tests/playwright-report/
+        retention-days: 30
+
+    - uses: actions/upload-artifact@v4
       with:
         name: myextension-sdist
         path: myextension.tar.gz
 
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v4
       with:
         name: myextension-nodejs
         path: myextension-nodejs.tgz
@@ -96,10 +103,10 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v2
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v4
       with:
         name: myextension-sdist
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v4
       with:
         name: myextension-nodejs
     - name: release

diff --git a/hatch_build.py b/hatch_build.py
@@ -22,6 +22,6 @@ class CustomHook(BuildHookInterface):
 
     def initialize(self, version, build_data):
         """Initialize the hook."""
-        if self.target_name not in ["wheel", "sdist"]:
+        if self.target_name not in ["sdist"]:
             return
         build_nbextension()