-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django 1.11 #126
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,23 @@ | ||
appdirs==1.4.3 | ||
defusedxml==0.5.0 | ||
Django==1.8 | ||
Django==1.11 | ||
django-ckeditor==5.1.1 | ||
django-email-extras==0.3.3 | ||
django-forms-builder==0.13.0 | ||
future==0.15.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are these dependencies required? |
||
oauthlib==1.1.2 | ||
Pillow==3.3.1 | ||
olefile==0.44 | ||
packaging==16.8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. really we need these? |
||
Pillow==4.0.0 | ||
PyJWT==1.4.2 | ||
python-social-auth==0.2.21 | ||
pyparsing==2.2.0 | ||
python-gnupg==0.4.0 | ||
python3-openid==3.0.10 | ||
pytz==2017.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this? |
||
requests==2.11.1 | ||
requests-oauthlib==0.6.2 | ||
six==1.10.0 | ||
django-ckeditor==5.1.1 | ||
django-forms-builder==0.13.0 | ||
social-auth-app-django==1.2.0 | ||
social-auth-core==1.3.0 | ||
sphinx-me==0.3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and why this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ankan17 and why these new requirements? sphinx? |
||
Unidecode==0.4.20 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why so many of these? Please remove the unnecessary ones. We only need google and facebook for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does having extra of these affect performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankan17 no but we must have clarity on why we need these. This might confuse us in future. Please remove the Twitter etc.