Use SWIG_AppendOutput to support swig 4.3 #256
Conversation
Swig has changed language specific AppendOutput functions. But helper macro SWIG_AppendOutput remains unchanged. Use that everywhere instead of SWIG_Python_AppendOutput, which would require one extra parameter since swig 4.3.0. https://github.com/swig/swig/blob/v4.3.0/CHANGES.current#L376 swig/swig#2905
|
I admit I am not sure how to test this change, whether it does not break functionality. But it builds. Original patch provided by swig maintainer. |
|
It seems most of failues are caused by not implemented CLA and IPN records, from https://datatracker.ietf.org/doc/draft-johnson-dns-ipn-cla/07/. Not related to these changes. |
|
PR #257 seems to be a duplicate of this proposal. Not sure if proposed by original change author, do not know his or her name. |
|
I'll have a look (also at the differences of the two PRs) next week or so, and credit both of you if it is indeed similar ;) |
|
My change were created by William @wsfulton, maintainer of swig. I have just added commit message to explain why it happened, but the code changes originate to William. I had just bare patch without commit message, I were unable to post original git change. I think #257 has the same source. Related links: |
|
Ideally William should create PR himself, so proper authorship is tracked on github. |
Swig has changed language specific AppendOutput functions. But helper macro SWIG_AppendOutput remains unchanged. Use that everywhere instead of SWIG_Python_AppendOutput, which would require one extra parameter since swig 4.3.0.
https://github.com/swig/swig/blob/v4.3.0/CHANGES.current#L376 swig/swig#2905