Add a merge unit. #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The base for the PR has become too outdated and it seemed easier to copy-paste the relevant bits into a new PR, #110, which now replaces it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new unit merges the content of the data sets from all configured upstream units.
Before we can, ehem, merge this, we need to add the ability for a unit to declare its data set outdated, so we don’t keep merging the data from a stalled unit. (Alternatively, units only stall once their data is considered outdated.)
Also, the internal use of serial numbers is inconsistent – I think we don’t actually need them at all.