Introduce daemonbase and use it for logging. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it wise to make |
|
A daemonbase release should probably happen before merging, indeed. |
ximon18
reviewed
Jan 29, 2024
ximon18
reviewed
Mar 11, 2024
ximon18
reviewed
Mar 11, 2024
| manager: &mut Manager, | ||
| ) -> Result<Self, Failed> { | ||
| let conf_path = cur_dir.join(matches.value_of("config").unwrap()); | ||
| let conf = match ConfigFile::load(&conf_path) { | ||
| let args = Args::from_arg_matches( |
There was a problem hiding this comment.
It's not clear to me why cur_dir is no longer needed here.
There was a problem hiding this comment.
Expansion of relative paths is now done transparently in daemonbase.
ximon18
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the logging configuration to use the new daemonbase crate.