Drops keeping serial number and diff with updates. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRiKE
approved these changes
Jan 26, 2024
partim
added a commit
that referenced
this pull request
May 29, 2024
Breaking Changes * Upgrade Rust edition, minimal Rust version to 1.70, and dependencies. ([#88], [#91]) * Removed internal serial numbers and the ability to pass optional diffs between units. ([#96]) New * Added a new `merge` unit that merges the datasets of all its sources. ([#110], [#113]) * Added four new configuration options to the HTTP client: * `http-root-certs` for additional TLS root certificates, * `http-user-agent` for setting a custom user agent, * `http-client-addr` to specify a local address to bind to, and * `http-proxies` to add HTTP proxies (only available if the `socks` feature is enabled which it is by default). ([#111]) * The RTR timer values can now be configured for the RTR target. ([#106]) * The RTR target now produces metrics. By setting `client-metrics: true` in its configuration, the target produces separate metrics for each client address. ([#115], [#117]) * Log changes made by the `slurm` unit to updates. ([#87]) * The `slurm` unit now updates its data set if it discovers that the Slurm files have changed. ([#89]) * Both the `json` unit and target now support conditional HTTP requests via the Etag and Last-Modified headers. ([#98]) Bug Fixes * Fix a race condition where the `slurm` unit would not apply its changes to the first update if loading the files is too slow. ([#89]) * Fixed various race conditions during startup and shutdown. ([#101]) Other Changes * Upgrade the packaging and Docker build workflow to allow for cross-compilation. ([#90])
partim
added a commit
that referenced
this pull request
Jun 6, 2024
Breaking Changes * Upgrade Rust edition, minimal Rust version to 1.70, and dependencies. ([#88], [#91]) * Removed internal serial numbers and the ability to pass optional diffs between units. ([#96]) New * Added a new `merge` unit that merges the datasets of all its sources. ([#110], [#113]) * Added four new configuration options to the HTTP client: * `http-root-certs` for additional TLS root certificates, * `http-user-agent` for setting a custom user agent, * `http-client-addr` to specify a local address to bind to, and * `http-proxies` to add HTTP proxies (only available if the `socks` feature is enabled which it is by default). ([#111]) * The RTR timer values can now be configured for the RTR target. ([#106]) * The RTR target now produces metrics. By setting `client-metrics: true` in its configuration, the target produces separate metrics for each client address. ([#115], [#117]) * Log changes made by the `slurm` unit to updates. ([#87]) * The `slurm` unit now updates its data set if it discovers that the Slurm files have changed. ([#89]) * Both the `json` unit and target now support conditional HTTP requests via the Etag and Last-Modified headers. ([#98]) Bug Fixes * Fix a race condition where the `slurm` unit would not apply its changes to the first update if loading the files is too slow. ([#89]) * Fixed various race conditions during startup and shutdown. ([#101]) Other Changes * Upgrade the packaging and Docker build workflow to allow for cross-compilation. ([#90])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the serial number and optional diff from
payload::Update.The serial number was never actually used anywhere so has always been unnecessary. However, it did provide a sort of safety net for using the optional diff in case an update was missed somehow. This, however, only ever happened with the RTR target, so dropping the diff and re-calculating is probably acceptable both from a performance and reliability perspective.