Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Q2 grid in generate_block #280

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix Q2 grid in generate_block #280

merged 1 commit into from
Jun 5, 2023

Conversation

giacomomagni
Copy link
Collaborator

This PR is the proper fix of NNPDF/nnpdf#1750

@giacomomagni giacomomagni added the bug Something isn't working label Jun 5, 2023
@giacomomagni giacomomagni self-assigned this Jun 5, 2023
alecandido
alecandido approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, you should also take care that all the nf values are consistent. But never mind, I hope this will become simpler with partons, I'm working on it :)

@alecandido alecandido mentioned this pull request Jun 5, 2023
Merged
@giacomomagni
Copy link
Collaborator Author

In principle, you should also take care that all the nf values are consistent.

Let's hope this is not causing any problem for the time being. 😅

felixhekhorn
felixhekhorn approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if part of NNPDF/nnpdf#1746 should be done (or repeated) here

@alecandido
Copy link
Member

I wonder if part of NNPDF/nnpdf#1746 should be done (or repeated) here

Don't waste too much effort on that, at least for a while more.

@giacomomagni giacomomagni merged commit 6e5dc8a into master Jun 5, 2023
@giacomomagni giacomomagni deleted the fix_q2_grid_generate_block branch June 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixhekhorn felixhekhorn felixhekhorn approved these changes

@alecandido alecandido alecandido approved these changes

@andreab1997 andreab1997 Awaiting requested review from andreab1997

Assignees

@giacomomagni giacomomagni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giacomomagni @alecandido @felixhekhorn