Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next runcards update #295

Merged
merged 15 commits into from
Aug 9, 2024
Merged

Next runcards update #295

merged 15 commits into from
Aug 9, 2024

Conversation

felixhekhorn
Copy link
Contributor

@felixhekhorn felixhekhorn commented Jul 31, 2023

Closes #248

#291 is already big enough on it's own and I expect even more changes here, because we're breaking a lot of stuff so I decided for a PR on its own ...

I won't drop n_integration_cores for the moment, because we are still missing the replacement: the actual jets runner

  • rerun all noteboooks
  • fix unit tests

@felixhekhorn felixhekhorn added enhancement New feature or request output Output format and management labels Jul 31, 2023
@felixhekhorn felixhekhorn mentioned this pull request Jul 31, 2023
@alecandido
Copy link
Member

I won't drop n_integration_cores for the moment, because we are still missing the replacement: the actual jets runner

I was not planning to write an "actual" jets runner in EKO ever. But if needed I can contribute the utilities for batching to Pineko.

What were your plans about it?

(I'd like, if possible, to drop even n_integration_cores before next release, to avoid another breaking one anytime soon)

@felixhekhorn felixhekhorn marked this pull request as ready for review August 1, 2023 15:33
@felixhekhorn
Copy link
Contributor Author

felixhekhorn commented Aug 1, 2023

current status:

  • drop max nf configurations: they were already not used, so here the impact is mild
  • drop runcards.update(): for us this is just a renaming, so again the impact should be mild, but this might effect the outside world ...
  • drop integration cores: as said, I won't do here since we're lacking an alternative at the moment - this is addressed in Improve runner API #296 and subsequent PRs in pineko (cc @andreab1997 )
  • evolution points in the runcard: here the impact is stronger, I'd say, especially since this is no doubt public API - we even shuffled stuff from theory to operators ($n_{f0}$)
  • drop intrinsic range: this had a huge impact, since I rooted it out at the bottom

all in all, this PR is very big (look at the number of files and we're impacting eko at it's core). This will require some extended testing for which I'd like to ask some help. We also need to decide if and what to do for the transition of the files from 0.13 to 0.14, which is a breaking change.

(I also need to fix LHA, but I believe that should be not too complicated)

@felixhekhorn
Copy link
Contributor Author

I believe the unit test failing in #291 is protected here by

eko/src/eko/io/runcards.py

Lines 216 to 218 in 7cf9e1b

nf_default(old_th["Q0"] ** 2.0, default_atlas(ms, ks))
if old_th["nf0"] is None
else old_th["nf0"],

Copy link
Collaborator

@giacomomagni giacomomagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also drop this?

def ffns(cls, nf: int, mu2: SquaredScale):

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment: here all the q2_grid are now evolgrid.

@felixhekhorn
Copy link
Contributor Author

Can we also drop this?

def ffns(cls, nf: int, mu2: SquaredScale):

Why? this is just an alternative constructor - which is handy at times ... (and there is no max nf business around - it just sets up correctly the thresholds ...)

Base automatically changed from mypy to master August 8, 2024 12:09
@felixhekhorn felixhekhorn merged commit 7d01a94 into master Aug 9, 2024
8 checks passed
@felixhekhorn felixhekhorn deleted the runcards-update-248 branch August 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request output Output format and management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next runcards update
4 participants