Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some pol tests #418

Merged
merged 19 commits into from
Oct 21, 2024
Merged

Add some pol tests #418

merged 19 commits into from
Oct 21, 2024

Conversation

giacomomagni
Copy link
Collaborator

@giacomomagni giacomomagni commented Oct 21, 2024

I think we can add this test on the polarized anomalous dimension.
(I messed up with the history because I started branching from the wrong branch)

@felixhekhorn
Copy link
Contributor

I was about to complain about the base branch 🙃 in this case maybe a rebase would be appropriate (or cherry-pick to a new branch)

can you please add the LO and NLO also to the Rust side?


(sorry in this intermediate state we have code duplication ...)

@felixhekhorn felixhekhorn added the benchmarks Benchmark (or infrastructure) related label Oct 21, 2024
@giacomomagni
Copy link
Collaborator Author

how do I access the beta function in the rust crates?

@felixhekhorn
Copy link
Contributor

how do I access the beta function in the rust crates?

eeehm, good point - it is currently not available

mmm let me think a moment ... 🤔

  1. the easy solution is just to ignore the Rust again for the moment in this PR (and delay the problem)
  2. if we want to do the proper thing, we need to find a good place on the Rust side; I'm thinking about adding yet another crate, random name suggestion: ekoupling, where we provide quasi the equivalent to the eko.couplings module: specifically, the beta functions and their solution. I'm worried about dependency management and how to disentangle stuff. Do you have an opinion? @tgiani may I ask for your opinion as well?

@giacomomagni
Copy link
Collaborator Author

  1. the easy solution is just to ignore the Rust again for the moment in this PR (and delay the problem)
  2. if we want to do the proper thing, we need to find a good place on the Rust side; I'm thinking about adding yet another crate, random name suggestion: ekoupling, where we provide quasi the equivalent to the eko.couplings module: specifically, the beta functions and their solution. I'm worried about dependency management and how to disentangle stuff. Do you have an opinion? @tgiani may I ask for your opinion as well?

So regarding this PR, I'd postpone the problem, it's just an additional test, I can add the one unrelated to be beta function.
For the long terms strategy I think we should provide the ekoupling module, but maybe you can add this to the oxidation road map or another issue.

Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as already said: maybe we can clean the commit history a bit (or we just keep it as is)

@felixhekhorn felixhekhorn mentioned this pull request Oct 21, 2024
13 tasks
@felixhekhorn
Copy link
Contributor

ehm, now I wonder if we should hard code beta0, i.e. sacrifice code duplication for an additional test ...

@tgiani
Copy link
Contributor

tgiani commented Oct 21, 2024

how do I access the beta function in the rust crates?

eeehm, good point - it is currently not available

mmm let me think a moment ... 🤔

  1. the easy solution is just to ignore the Rust again for the moment in this PR (and delay the problem)
  2. if we want to do the proper thing, we need to find a good place on the Rust side; I'm thinking about adding yet another crate, random name suggestion: ekoupling, where we provide quasi the equivalent to the eko.couplings module: specifically, the beta functions and their solution. I'm worried about dependency management and how to disentangle stuff. Do you have an opinion? @tgiani may I ask for your opinion as well?

I would agree with what Giacomo said, so delay the problem for the time being and put an ekoupling implementation on the to do list

@giacomomagni giacomomagni merged commit 5d4dbd3 into master Oct 21, 2024
6 of 7 checks passed
@giacomomagni giacomomagni deleted the add_some_pol_tests branch October 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Benchmark (or infrastructure) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants