Improve DataSet covmat

[scarrazza]

Issue by Zaharid
Monday Jul 03, 2017 at 14:28 GMT
Originally opened as https://github.com/NNPDF/libnnpdf/issues/27

---

This should work along the lines of #23.
In the bigger picture, the covmat should not be computed by default #24 and it's not clear to me it should be owned by the object at all #4.

[scarrazza]

Comment by Zaharid
Monday Jan 29, 2018 at 16:06 GMT

---

Mmm, I don't think this one was ever fixed.

[scarrazza]

Comment by nhartland
Monday Jan 29, 2018 at 16:42 GMT

---

Isn't it through the matrix class Stefano wrote? I took a quick look and it
seemed fine to me. (I could be mixing up issues though, there are a few
covmat ones)

On 29 Jan 2018 17:06, "Zaharid" [email protected] wrote:

Mmm, I don't think this one was ever fixed.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/NNPDF/libnnpdf/issues/27#issuecomment-361294180, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE_NDOMB_3hMXoSYn-LpjMvojFZhUamLks5tPex6gaJpZM4OMW7B
.

[scarrazza]

Comment by Zaharid
Monday Jan 29, 2018 at 16:46 GMT

---

No. This is about the fact that the covmat generation for datasets is very slow. I improved it for Experiment in #23, but didn't touch dataset, which is a-copy-but-not-quite. In fact it made me wonder why we want to have dataset and experiment in the first place, as opposed to a data containter with no operations (dataset) and with operations, Experiment.

[scarrazza]

Comment by nhartland
Monday Jan 29, 2018 at 19:37 GMT

---

Ah ok, I did leave a covmat issue open to keep the problem alive, but if
you prefer feel free to reopen.

On 29 Jan 2018 5:46 pm, "Zaharid" [email protected] wrote:

No. This is about the fact that the covmat generation for datasets is very
slow. I improved it for Experiment in #23
https://github.com/NNPDF/libnnpdf/pull/23, but didn't touch dataset,
which is a-copy-but-not-quite. In fact it made me wonder why we want to
have dataset and experiment in the first place, as opposed to a data
containter with no operations (dataset) and with operations, Experiment.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/NNPDF/libnnpdf/issues/27#issuecomment-361307922, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE_NDPCF_L6V1fpGrUIouiPmLxdsl5wxks5tPfXpgaJpZM4OMW7B
.

[Zaharid]

Closed in favour of #21.