Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the input variable when checking old-new for DW datasets #2195

Merged
merged 1 commit into from
Nov 1, 2024
+3 −1
Merged

Don't change the input variable when checking old-new for DW datasets #2195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
dont change the input variable
@scarlehoff
scarlehoff committed Nov 1, 2024
commit 581829c03018759091cd489ae89722ff67bdd52a
2 changes: 1 addition & 1 deletion nnpdf_data/nnpdf_data/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@ def new_to_legacy_map(dataset_name, variant_used):
matches.append(old_name)
# if it's a nuclear DIS data promote legacy to be legacy_dw
if "_DW_" in old_name and variant_used == "legacy":
variant_used = "legacy_dw"
variant = "legacy_dw"

if variant_used == variant:
exact_matches.append(old_name)
2 changes: 2 additions & 0 deletions validphys2/src/validphys/tests/test_commondataparser.py
View file
Original file line number Diff line number Diff line change
@@ -128,3 +128,5 @@ def test_variant_nnpdf_metadata():
assert pcd2.experiment != pcd1.experiment
# but the real experiment is the same
assert cd1.metadata.experiment == cd2.metadata.experiment
# And check that the legacy names are _not_ the same
assert cd1.legacy_names != cd2.legacy_names