Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make yadism compute save scale info by default #71

Merged
merged 2 commits into from
Apr 17, 2024
Merged

make yadism compute save scale info by default #71

merged 2 commits into from
Apr 17, 2024

Conversation

scarlehoff
Copy link
Member

andreab1997
andreab1997 reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is fine like that. What is your opinion @felixhekhorn @alecandido ?

felixhekhorn
felixhekhorn approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright (I haven't tested it 😇 )

@felixhekhorn felixhekhorn added the enhancement New feature or request label Apr 17, 2024
@scarlehoff scarlehoff merged commit 31f3f41 into main Apr 17, 2024
5 checks passed
@scarlehoff scarlehoff deleted the scaleinfo_in_yadism branch April 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreab1997 andreab1997 andreab1997 left review comments

@felixhekhorn felixhekhorn felixhekhorn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarlehoff @felixhekhorn @andreab1997