Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nnpdf single-truth theory #169

Merged
merged 18 commits into from
Jun 6, 2024
Merged

Use nnpdf single-truth theory #169

merged 18 commits into from
Jun 6, 2024

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Apr 11, 2024

Changes to use NNPDF/nnpdf#2028 with pineko.

At the moment it doesn't do anything clever, it just loads the yaml from there. I've tested the eko and fktable generation.
(the tests and so won't pass until the PR is merged in nnpdf)

@felixhekhorn felixhekhorn added the enhancement New feature or request label May 2, 2024
@scarlehoff
Copy link
Member Author

scarlehoff commented May 2, 2024

I've made a change (wrt #146). Now if the template and the theory have a different mu0 this raises an Exception instead of overwriting the value silently.
I can revert the change back of course, but I think this is something important enough to be fail as early as possible (and the solution is "simply" to change the template or theory if one really wants to play god).

Note, the benchmarks have changed because I'm putting theory > template but maybe we want the template to take over?

@scarlehoff scarlehoff force-pushed the use_nnpdf_theory branch 2 times, most recently from 39f100c to ef295c0 Compare May 2, 2024 15:21
src/pineko/evolve.py Outdated Show resolved Hide resolved
@scarlehoff
Copy link
Member Author

One problem here is the nfonnl part.
However, I believe that, since now one can run nfonll by providing only the main theory id, the only logical thing is that the theory cards can also be autogenerated in the go (and so tcards should not be necessary).

This helps reducing the extra amount of theory cards and having to tell NNPDF about things like PTOEKO or FONLLParts.

@scarlehoff
Copy link
Member Author

With the last commit from here NNPDF/nnpdf#2067
this works with pineko to create theories without having to provide a theory or yamldb folder.

Copy link
Contributor

@giacomomagni giacomomagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two two useless comments.

docs/source/overview/running.rst Outdated Show resolved Hide resolved
src/pineko/theory.py Outdated Show resolved Hide resolved
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped most of the yamldb stuff, because it is not used here and nowhere else

Co-authored-by: Giacomo Magni <[email protected]>
@scarlehoff scarlehoff merged commit 04a7252 into main Jun 6, 2024
6 checks passed
@scarlehoff scarlehoff deleted the use_nnpdf_theory branch June 6, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants