-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nnpdf single-truth theory #169
Conversation
4559a06
to
6352ecc
Compare
I've made a change (wrt #146). Now if the template and the theory have a different Note, the benchmarks have changed because I'm putting theory > template but maybe we want the template to take over? |
39f100c
to
ef295c0
Compare
One problem here is the nfonnl part. This helps reducing the extra amount of theory cards and having to tell NNPDF about things like |
4b73e8a
to
d79053e
Compare
With the last commit from here NNPDF/nnpdf#2067 |
0d14aa9
to
8170f63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two two useless comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped most of the yamldb stuff, because it is not used here and nowhere else
Co-authored-by: Giacomo Magni <[email protected]>
Co-authored-by: Felix Hekhorn <[email protected]>
Changes to use NNPDF/nnpdf#2028 with pineko.
At the moment it doesn't do anything clever, it just loads the yaml from there. I've tested the eko and fktable generation.
(the tests and so won't pass until the PR is merged in nnpdf)