Reportengine CI #65
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Reportengine tests | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.12"] | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Setup Miniconda | ||
| uses: conda-incubator/setup-miniconda@v3 | ||
| with: | ||
| activate-environment: test | ||
| use-mamba: true | ||
|
|
||
| - name: Update Environment | ||
| shell: bash -l {0} | ||
| run: | | ||
| conda env update -n test -f environment.yml | ||
|
There was a problem hiding this comment. Oh I thought I wrote a comment on this as well. Anyway, why do you not just do There was a problem hiding this comment. Hi Roy, sorry for the very late reply. I somehow forgot about this PR. I think that having the environment.yml has the advantage of allowing the user to install reportengine and creating a conda env at the same time:
If we agree on keeping the env file, then why not using it directly in the CI? There was a problem hiding this comment. Also a long time ago for me... Anyway, the dependencies are already defined in meta.yaml for installing with conda and pyproject.toml for python. In the test you already build the conda package, so you could create an env using the local package and run the test on that. That way you don't have to define the dependencies in yet another place. Also There was a problem hiding this comment. Can you be a bit more specific please? |
||
|
|
||
| - name: Install pytest dependencies | ||
| shell: bash -l {0} | ||
| run: | | ||
| pip install pytest | ||
| pip install hypothesis | ||
|
|
||
| - name: Run Tests | ||
| shell: bash -l {0} | ||
| run: | | ||
| pytest | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: reportengine | ||
|
|
||
| channels: | ||
| - conda-forge | ||
|
|
||
|
|
||
| dependencies: | ||
| - python | ||
| - flit | ||
| - jinja2 | ||
| - ruamel_yaml =0.15 | ||
| - matplotlib | ||
| - pandas >=1 | ||
| - pygments | ||
| - blessings | ||
| - pandoc >=2 | ||
| - dask | ||
| - pip: | ||
| - . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need both of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RoyStegeman, thanks for the comments.
The conda environment is needed because of pandoc. Does that answer your question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That I understood, but why do you need the python one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now the first step is needed to fix the python version.
But I guess we could do it directly in the miniconda env.
I can try to do so if you prefer it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it supports a
python-versionkey, so I guess it makes sense to use that