-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to MOPITT pairing #316
base: develop
Are you sure you want to change the base?
Changes to MOPITT pairing #316
Conversation
…k/MELODIES-MONET into develop_tropomifix
melodies_monet/driver.py
Outdated
@@ -287,6 +287,13 @@ def open_sat_obs(self, time_interval=None, control_dict=None): | |||
else: flst = self.file | |||
self.obj = mio.sat._mopitt_l3_mm.open_dataset(flst, ['column','pressure_surf','apriori_col', | |||
'apriori_surf','apriori_prof','ak_col']) | |||
|
|||
# Determine if monthly or daily product and set as attribute | |||
if 'MOP03JM' in glob(self.file)[0]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add in options for MOP03NM and MOP03TM for NIR and TIR only L3 files
if obs.obs_type.lower() in list(self.pairing_kwargs.keys()): | ||
pairing_kws = self.pairing_kwargs[obs.obs_type.lower()] | ||
else: | ||
pairing_kws = {'apply_ak': True, 'mod_to_overpass': False} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add an error message as to why MM might break if no AK is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Ready to merge once those other 2 Level3 options are added.
Adds utility for sampling model data to satellite local overpass time.
Modifies MOPITT L3 pairing to calculate model averages using only model data at the satellite overpass time.
Also ensures that model is paired to correct obs time. Previously assumed that model and obs datasets were on same time at that point, but this isn't true if there are gaps in the obs dataset.
New argument for the yaml file if model output hasn't been pre-processed to monthly mean: mod_to_overpass.
Note: Insert/delete flagging includes some commits from other recent pull requests (#304, #312 ).