Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to MOPITT pairing #316

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

mbruckner-work
Copy link
Collaborator

Adds utility for sampling model data to satellite local overpass time.

Modifies MOPITT L3 pairing to calculate model averages using only model data at the satellite overpass time.
Also ensures that model is paired to correct obs time. Previously assumed that model and obs datasets were on same time at that point, but this isn't true if there are gaps in the obs dataset.

New argument for the yaml file if model output hasn't been pre-processed to monthly mean: mod_to_overpass.

Note: Insert/delete flagging includes some commits from other recent pull requests (#304, #312 ).

@rschwant rschwant requested a review from rrbuchholz February 10, 2025 18:32
@@ -287,6 +287,13 @@ def open_sat_obs(self, time_interval=None, control_dict=None):
else: flst = self.file
self.obj = mio.sat._mopitt_l3_mm.open_dataset(flst, ['column','pressure_surf','apriori_col',
'apriori_surf','apriori_prof','ak_col'])

# Determine if monthly or daily product and set as attribute
if 'MOP03JM' in glob(self.file)[0]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in options for MOP03NM and MOP03TM for NIR and TIR only L3 files

if obs.obs_type.lower() in list(self.pairing_kwargs.keys()):
pairing_kws = self.pairing_kwargs[obs.obs_type.lower()]
else:
pairing_kws = {'apply_ak': True, 'mod_to_overpass': False}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add an error message as to why MM might break if no AK is available.

Copy link
Collaborator

@rrbuchholz rrbuchholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ready to merge once those other 2 Level3 options are added.

@mbruckner-work mbruckner-work marked this pull request as ready for review February 13, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants