-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update #322
base: develop
Are you sure you want to change the base?
Docs update #322
Conversation
Add Maggie, Rebecca and Pablo as code reviewers Still missing: Quazi, Beiming, probably others.
Please add me! @blychs |
@btang1 I need a short description to add (look at the others that are already there). As I said, that's the reason I'm keeping it as a draft. |
@btang1 @mbruckner-work @quaz115 Make sure that yours looks alright. If it does not, let me know. The faster we can merge this the better, and it should be pretty straightforward. |
@blychs Looks good for me! thanks for organizing |
@blychs Looks good to me as well! |
Co-authored-by: Zachary Moon <[email protected]>
@blychs for 'develop team rst' can you add in line 33, thanks! |
Updating beiming
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just suggested one small update for a reference for GitHub help to be consistent with my other updates on ReadTheDocs to go into this PR too.
Sounds good Co-authored-by: Becky Schwantes <[email protected]>
Just changed it to be a PR to develop |
Hi all,
This PR includes two main updates:
a) Update the developers team. I added myself, @rrbuchholz and @mbruckner-work as reviewers. It is still missing some people (e.g., @quaz115, @btang1 ), so I am keeping it as a draft until they are added. I just don't have enough information about their interests to add them. In the case of @mbruckner-work, it definitely needs updates as well.
b) Add schematic to developers guide (suggested by @rschwant). I don't know if I added it to the right place.
Cheers
Pablo