Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #322

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Docs update #322

wants to merge 11 commits into from

Conversation

blychs
Copy link
Collaborator

@blychs blychs commented Dec 4, 2024

Hi all,
This PR includes two main updates:
a) Update the developers team. I added myself, @rrbuchholz and @mbruckner-work as reviewers. It is still missing some people (e.g., @quaz115, @btang1 ), so I am keeping it as a draft until they are added. I just don't have enough information about their interests to add them. In the case of @mbruckner-work, it definitely needs updates as well.
b) Add schematic to developers guide (suggested by @rschwant). I don't know if I added it to the right place.
Cheers
Pablo

	Add Maggie, Rebecca and Pablo as code reviewers
	Still missing: Quazi, Beiming, probably others.
@blychs blychs requested review from zmoon and rschwant December 4, 2024 01:44
@blychs blychs marked this pull request as draft December 4, 2024 01:44
@btang1
Copy link
Contributor

btang1 commented Dec 4, 2024

Please add me! @blychs

@blychs
Copy link
Collaborator Author

blychs commented Dec 4, 2024

@btang1 I need a short description to add (look at the others that are already there). As I said, that's the reason I'm keeping it as a draft.
Cheers

@blychs
Copy link
Collaborator Author

blychs commented Jan 15, 2025

@btang1 @mbruckner-work @quaz115 Make sure that yours looks alright. If it does not, let me know. The faster we can merge this the better, and it should be pretty straightforward.

@btang1
Copy link
Contributor

btang1 commented Jan 16, 2025

@btang1 @mbruckner-work @quaz115 Make sure that yours looks alright. If it does not, let me know. The faster we can merge this the better, and it should be pretty straightforward.

@blychs Looks good for me! thanks for organizing

@quaz115
Copy link
Collaborator

quaz115 commented Jan 16, 2025

@btang1 @mbruckner-work @quaz115 Make sure that yours looks alright. If it does not, let me know. The faster we can merge this the better, and it should be pretty straightforward.

@blychs Looks good for me! thanks for organizing

@blychs Looks good to me as well!

@btang1
Copy link
Contributor

btang1 commented Jan 16, 2025

@btang1 @mbruckner-work @quaz115 Make sure that yours looks alright. If it does not, let me know. The faster we can merge this the better, and it should be pretty straightforward.

@blychs for 'develop team rst' can you add in line 33,
'githubname: btang1; expertise: surface & ozone sonder doc, plot & stat"

thanks!

@blychs
Copy link
Collaborator Author

blychs commented Jan 16, 2025

@btang1 @mbruckner-work @quaz115 Make sure that yours looks alright. If it does not, let me know. The faster we can merge this the better, and it should be pretty straightforward.

@blychs for 'develop team rst' can you add in line 33, 'githubname: btang1; expertise: surface & ozone sonder doc, plot & stat"

thanks!

Done

@blychs blychs marked this pull request as ready for review February 6, 2025 01:48
Copy link
Collaborator

@rschwant rschwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just suggested one small update for a reference for GitHub help to be consistent with my other updates on ReadTheDocs to go into this PR too.

docs/develop/developers_guide.rst Outdated Show resolved Hide resolved
Sounds good

Co-authored-by: Becky Schwantes <[email protected]>
@blychs blychs changed the base branch from main to develop February 13, 2025 18:29
@blychs
Copy link
Collaborator Author

blychs commented Feb 13, 2025

Just changed it to be a PR to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants