-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/calculate columns #328
Open
blychs
wants to merge
11
commits into
NOAA-CSL:develop
Choose a base branch
from
blychs:feature/calculate_columns
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey all, I would like to use this PR for the Pandora total column comparisons. This means that the faster it can be reviewed (and hopefully any bugs fixed!), the better. If it is, we could also update the other satellite tools to use this, and reduce code duplication. |
zmoon
reviewed
Feb 6, 2025
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
blychs
commented
Feb 6, 2025
DWesl
reviewed
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to calculat partial/total columns and local geographic time in tools.py, since this is used by TEMPO, TROPOMI, and will be used by Pandora and others, and right now it was coded over and over again.
Also, move import xarray to the top. It's called by many functions and that is the recommended practice according to PEP8. I don't see any good reason to not have it at the top.