Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added catch by fleet diagnostics #37

Merged
merged 3 commits into from
Sep 23, 2024
Merged

added catch by fleet diagnostics #37

merged 3 commits into from
Sep 23, 2024

Conversation

jcaracappa1
Copy link
Contributor

  • magnitude of catch
  • center of gravity of catch

- magnitude of catch
- center of gravity of catch
@andybeet
Copy link
Member

andybeet commented Sep 20, 2024

@jcaracappa1 At first glance we are using different argument names and output names for the same things across functions. eg. fgs (used in other diagnostics function) vs fgs.file (in this new function) vs groups.file (output of get_atl_parmamfiles). Same thing with fishery/catch files. Not something i am suggesting we should fix now but might be worth doing/addressing in the future

EDIT: the explanation of some of the arguments look like they are left over from another function

@jcaracappa1
Copy link
Contributor Author

Which argument names look unchanged?

@jcaracappa1
Copy link
Contributor Author

@andybeet Do you think we should rename anything before merging?

@jcaracappa1
Copy link
Contributor Author

@andybeet That should be fixed now

@andybeet
Copy link
Member

i dont think this will run. still left over names in code. But i dont have a catch.ref object to test it

@jcaracappa1
Copy link
Contributor Author

@andybeet Good catch. updated.

@andybeet andybeet merged commit 1174b52 into main Sep 23, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants