Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fun with unk #51

Merged
merged 20 commits into from
Oct 31, 2023
Merged

Fun with unk #51

merged 20 commits into from
Oct 31, 2023

Conversation

slucey
Copy link
Member

@slucey slucey commented Oct 31, 2023

Fixed how unknowns are calculated

Sean Lucey and others added 20 commits December 16, 2022 14:16
fixed NaN caused by zeros in denominator
9794add
Added ID to unknown records
a0cbe6b
Proportioned value
bbe6349
Forgot to remove ID column before merging back
83bcdcb
Switched all unknown variables to NA instead of 0 or 999
5227ac4
Identify complete cases and which strata are unknown
8dc25b7
Need to update comdata if running multiple variables
4629427
Forgot to remove ID tag from unknowns
e25cb7c
Needed na.rm in sum commands
dea332f
Added combinations...removed NESPP3 and Year from stratification
ab33fcd
Added 3 and 5 year window and species only
5fb7b25
Forgot to remove line used for testing
4422236
Two NAFO divisions from GB were missing
625b29b
Added allow.cartesian for duplicate areas
5079bb1
Added area 538 to GB and 611 to MAB
f98fc32
Removed semicolon from query because it was not working
8e22ef3
Merge pull request #50 from NOAA-EDAB/dev
c7856f1 
Dev
Merge branch 'funWithUnk' of github.com:NOAA-EDAB/comlandr into funWi…
b13cf28 
…thUnk
Added flag so that areas can be assigned without being species specific
8966280
Add applyProp argument to get_comland_data
320f64b
@slucey slucey requested a review from andybeet October 31, 2023 15:32
@slucey slucey linked an issue Oct 31, 2023 that may be closed by this pull request
Ensure overhauled package is consistent with old data pulls #49
Open
@andybeet andybeet merged commit 288857f into dev Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybeet andybeet Awaiting requested review from andybeet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure overhauled package is consistent with old data pulls
2 participants
@slucey @andybeet