Initial commit of marine letkf stubs #1090
Conversation
AndrewEichmann-NOAA
requested review from
givelberg,
CoryMartin-NOAA,
guillaumevernieres and
apchoiCMD
| logger = getLogger(__name__.split('.')[-1]) | ||
|
|
||
|
|
||
| class MarineLETKF(Task): |
There was a problem hiding this comment.
I know Analysis task has a few (2) atmosphere specific methods, but the constructor for it sets up the window, etc. Also, there are generic methods to construct the JEDI yaml, copy observations, etc.
This class deviates from the framework that the other analysis tasks are developed around.
If there is a need to update Analysis task to be further accommodating of ocean/seaice requirements, it would be better to discuss and develop rather than have to revisit when there is a crunch.
There was a problem hiding this comment.
That's why we added you as a reviewer and that's what a PR is for @aerorahul, discuss.
Can you switch to using Analysis as parent class @AndrewEichmann-NOAA ? Also, while re-reading your code, I saw a few places where you are using recentering instead of letkf.
Adds stubs and ctest for marine LETKF task. Co-dependent on global-workflow PR NOAA-EMC/global-workflow#2564
Addresses #1091