Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed and reapportioned yamls for letkf task #1212

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Renames/moves common yamls from letkf subdir and rearranges contents to serve for tools common to SOCA

Another step toward resolving #1091, paired with g-w
NOAA-EMC/global-workflow#2635

@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review July 5, 2024 18:33
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now. But do address the cosmetic comment and add a reminder that the yaml for staging the fix files is resolution dependent.

parm/soca/soca_ens_bkg_stage.yaml.j2 Show resolved Hide resolved
parm/soca/soca_fix_stage.yaml.j2 Show resolved Hide resolved
@AndrewEichmann-NOAA
Copy link
Collaborator Author

Includes workaround described in #1213

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumevernieres guillaumevernieres merged commit 134ad36 into develop Jul 8, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/letkf-yaml-updates branch July 8, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants