Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIRS sea-ice product to ioda converter #1238

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add MIRS sea-ice product to ioda converter #1238

merged 3 commits into from
Jul 30, 2024

Conversation

apchoiCMD
Copy link
Collaborator

Description

  • Task for adding a new ioda converter for new sea-ice concentration
  • For sea-ice, AMSR2 and MIRS product will be used

Partially addressed #1182

guillaumevernieres
guillaumevernieres reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the test cdl files need to be smaller. 15,000 lines is definitely too large, target something ~1000 lines or less.

@AndrewEichmann-NOAA
Copy link
Collaborator

Looks reasonable

@apchoiCMD
Copy link
Collaborator Author

Looks good but the test cdl files need to be smaller. 15,000 lines is definitely too large, target something ~1000 lines or less.

Replaced with sub-sampled ones, now ~960 lines-

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jul 30, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 30, 2024
@emcbot
Copy link

emcbot commented Jul 30, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Jul 30 19:38:41 UTC 2024 on hfe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jul 30 20:23:09 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jul 30 20:44:19 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 44

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 30, 2024
@guillaumevernieres guillaumevernieres merged commit 7e09cdc into develop Jul 30, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/snpp_sea_ice branch July 30, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA left review comments

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@JohnSteffen-NOAA JohnSteffen-NOAA Awaiting requested review from JohnSteffen-NOAA

@givelberg givelberg Awaiting requested review from givelberg

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apchoiCMD @AndrewEichmann-NOAA @emcbot @guillaumevernieres