Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug for empty files #1351

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Conversation

givelberg
Copy link
Collaborator

Added testing for empty files and logging the number of obs.
The code exits if the filtering results in no data, so no output file is created.

Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

altkob converter is not committed here
@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Nov 1, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Nov 1, 2024
@emcbot
Copy link

emcbot commented Nov 1, 2024

Automated GW GDASApp Testing Results:
Machine: hera

Start: Fri Nov  1 16:27:54 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Nov  1 17:17:22 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Nov  1 20:22:53 UTC 2024
Tests: 58% tests passed, 23 tests failed out of 55
	1955 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marinebmat_202103241800 (Failed)
	1956 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlinit_202103241800 (Failed)
	1957 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlvar_202103241800 (Failed)
	1958 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlchkpt_202103241800 (Failed)
	1963 - test_gdasapp_atm_jjob_var_init (Failed)
	1964 - test_gdasapp_atm_jjob_var_run (Failed)
	1965 - test_gdasapp_atm_jjob_var_inc (Failed)
	1966 - test_gdasapp_atm_jjob_var_final (Failed)
	1971 - test_gdasapp_atm_jjob_ens_sol (Failed)
	1972 - test_gdasapp_atm_jjob_ens_inc (Failed)
	1973 - test_gdasapp_atm_jjob_ens_final (Failed)
	1975 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
	1976 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
	1977 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
	1978 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
	1979 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
	1980 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
	1981 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
	1982 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1351/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 1, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Nov 6, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Nov 6, 2024
@emcbot
Copy link

emcbot commented Nov 6, 2024

Automated GW GDASApp Testing Results:
Machine: hera

Start: Wed Nov  6 18:55:28 UTC 2024 on hfe02
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Nov  6 19:44:29 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Nov  6 20:21:07 UTC 2024
Tests: 78% tests passed, 12 tests failed out of 55
	1955 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marinebmat_202103241800 (Failed)
	1956 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlinit_202103241800 (Failed)
	1957 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlvar_202103241800 (Failed)
	1958 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlchkpt_202103241800 (Failed)
	1959 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlfinal_202103241800 (Failed)
	1963 - test_gdasapp_atm_jjob_var_init (Failed)
	1964 - test_gdasapp_atm_jjob_var_run (Failed)
	1965 - test_gdasapp_atm_jjob_var_inc (Failed)
	1966 - test_gdasapp_atm_jjob_var_final (Failed)
	1971 - test_gdasapp_atm_jjob_ens_sol (Failed)
	1972 - test_gdasapp_atm_jjob_ens_inc (Failed)
	1973 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1351/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 6, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @givelberg . The ci failures are unrelated to your work.

@guillaumevernieres guillaumevernieres merged commit 4c9b1d2 into develop Nov 6, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the bugfix/b2iemptyfile branch November 6, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants