Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JEDI hashes to include Model Variable Renaming Sprint #1355

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Oct 30, 2024

This PR updates JEDI hashes in sorc/ to bring in changes associated with the Model Variable Renaming Sprint. This is required to fully resolve #1313.

Resolves #1313
Resolves #1362

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Oct 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Oct 30, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Oct 30, 2024
@emcbot
Copy link

emcbot commented Oct 30, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Oct 30 16:11:17 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct 30 16:11:48 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Oct 30 16:11:51 UTC 2024
Tests: 

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Oct 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Oct 30, 2024
@emcbot
Copy link

emcbot commented Oct 30, 2024

Automated GDASApp Testing Results:
Machine: hera

Start: Wed Oct 30 18:10:20 UTC 2024 on hfe04
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Wed Oct 30 19:08:03 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/PR/1355/GDASApp/log.build

@emcbot emcbot added the hera-RT-Passed Automated testing successful on Hera label Oct 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT Queue for automated testing on Hera hera-RT-Passed Automated testing successful on Hera labels Oct 30, 2024
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Oct 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT-Running Automated testing running on Hera labels Oct 30, 2024
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Oct 30, 2024
@emcbot
Copy link

emcbot commented Oct 30, 2024

Automated GDASApp Testing Results:
Machine: hera

Start: Wed Oct 30 19:40:23 UTC 2024 on hfe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct 30 20:32:02 UTC 2024
---------------------------------------------------

@emcbot emcbot added hera-RT-Failed Automated testing failed on Hera and removed hera-RT-Running Automated testing running on Hera labels Oct 30, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT-Failed Automated testing failed on Hera labels Oct 31, 2024
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Oct 31, 2024
@emcbot
Copy link

emcbot commented Oct 31, 2024

Automated GDASApp Testing Results:
Machine: hera

Start: Thu Oct 31 10:24:14 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Oct 31 11:12:02 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Oct 31 11:14:12 UTC 2024
Tests: 76% tests passed, 8 tests failed out of 33
	1953 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
	1954 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
	1955 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
	1956 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
	1957 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
	1958 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
	1959 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
	1960 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/PR/1355/GDASApp/build/log.ctest

@emcbot emcbot added hera-RT-Failed Automated testing failed on Hera and removed hera-RT-Running Automated testing running on Hera labels Nov 1, 2024
@emcbot
Copy link

emcbot commented Nov 1, 2024

Automated GW GDASApp Testing Results:
Machine: hera

Start: Fri Nov  1 11:08:13 UTC 2024 on hfe09
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Nov  1 11:59:19 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Nov  1 12:38:11 UTC 2024
Tests: 73% tests passed, 15 tests failed out of 55
	1963 - test_gdasapp_atm_jjob_var_init (Failed)
	1964 - test_gdasapp_atm_jjob_var_run (Failed)
	1965 - test_gdasapp_atm_jjob_var_inc (Failed)
	1966 - test_gdasapp_atm_jjob_var_final (Failed)
	1971 - test_gdasapp_atm_jjob_ens_sol (Failed)
	1972 - test_gdasapp_atm_jjob_ens_inc (Failed)
	1973 - test_gdasapp_atm_jjob_ens_final (Failed)
	1975 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
	1976 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
	1977 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
	1978 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
	1979 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
	1980 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
	1981 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
	1982 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1355/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 1, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Create dummy g-w PR #3052 with branch name feature/resume_nightly. hera-GW-RT should detect that this g-w branch exists and clone it instead of g-w develop.

@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Nov 1, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Nov 1, 2024
@emcbot
Copy link

emcbot commented Nov 1, 2024

Automated GW GDASApp Testing Results:
Machine: hera

Start: Fri Nov  1 13:27:04 UTC 2024 on hfe02
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Nov  1 14:14:44 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Nov  1 14:56:28 UTC 2024
Tests: 73% tests passed, 15 tests failed out of 55
	1963 - test_gdasapp_atm_jjob_var_init (Failed)
	1964 - test_gdasapp_atm_jjob_var_run (Failed)
	1965 - test_gdasapp_atm_jjob_var_inc (Failed)
	1966 - test_gdasapp_atm_jjob_var_final (Failed)
	1971 - test_gdasapp_atm_jjob_ens_sol (Failed)
	1972 - test_gdasapp_atm_jjob_ens_inc (Failed)
	1973 - test_gdasapp_atm_jjob_ens_final (Failed)
	1975 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
	1976 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
	1977 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
	1978 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
	1979 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
	1980 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
	1981 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
	1982 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1355/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 1, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Test was successful in that the dummy g-w PR #3052 was installed with GDAApp branch feature/resume_nightly cloned inside sorc/gdas.cd.

@RussTreadon-NOAA
Copy link
Contributor Author

Close g-w PR #3052 upon completion of successful test.

@RussTreadon-NOAA
Copy link
Contributor Author

Remove Dummy from title and place in draft mode.

Execute ush/submodules/update_develop.sh in working copy of feature/resume_nightly. Working through yaml and template changes required by JEDI model variable renaming sprint.

@RussTreadon-NOAA RussTreadon-NOAA changed the title Dummy PR for Hera CI testing (DO NOT MERGE) Update JEDI hashes to includeModel Variable Renaming Sprint Nov 3, 2024
@RussTreadon-NOAA RussTreadon-NOAA changed the title Update JEDI hashes to includeModel Variable Renaming Sprint Update JEDI hashes to include Model Variable Renaming Sprint Nov 3, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA , I am getting the error

ValueError: The dictionary of templates must have an algorithm key

when running test_gdasapp_atm_jjob_var_init using GDASApp branch feature/resume_nightly_mod inside g-w develop at 152bb45.

I'm thinking that I need to update my copy of g-w to your DavidNew-NOAA:feature/jcb-obsbias from g-w PR #2992. I wanted to run this by you before updating and rebuilding.

@DavidNew-NOAA
Copy link
Collaborator

DavidNew-NOAA commented Nov 5, 2024 via email

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as draft November 5, 2024 19:40
@RussTreadon-NOAA
Copy link
Contributor Author

Will keep this PR in draft mode until GDASApp and jcb-gdas yamls and templates work with updated JEDI hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera hera-RT-Failed Automated testing failed on Hera
Projects
None yet
3 participants