-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JEDI hashes to include Model Variable Renaming Sprint #1355
base: develop
Are you sure you want to change the base?
Conversation
Automated Global-Workflow GDASApp Testing Results:
|
Automated GDASApp Testing Results:
|
Automated GDASApp Testing Results:
|
Automated GDASApp Testing Results:
|
Automated GW GDASApp Testing Results:
|
Create dummy g-w PR #3052 with branch name |
Automated GW GDASApp Testing Results:
|
Test was successful in that the dummy g-w PR #3052 was installed with GDAApp branch |
Close g-w PR #3052 upon completion of successful test. |
Remove Dummy from title and place in draft mode. Execute |
@DavidNew-NOAA , I am getting the error
when running I'm thinking that I need to update my copy of g-w to your |
Hi Russ,
Hmmm. Because #2992 <NOAA-EMC/global-workflow#2992> is
still in review but its companion PR in GDASApp was merged, the jjob tests
shouldn't pass. That was the one thing that that GDASApp PR did break,
though I would expect a slightly different error.
I would first try reverting test/atm/global-workflow/config.yaml to the
follow hash and let me know what happens:
9d95c9d
I have a meeting with Rahul and Walter at 11 AM to get this #2992
<NOAA-EMC/global-workflow#2992> business sorted
out, so hopefully this problem will soon be irrelevant.
David
…On Tue, Nov 5, 2024 at 9:32 AM RussTreadon-NOAA ***@***.***> wrote:
@DavidNew-NOAA <https://github.com/DavidNew-NOAA> , I am getting the error
ValueError: The dictionary of templates must have an algorithm key
when running test_gdasapp_atm_jjob_var_init using GDASApp branch
feature/resume_nightly_mod inside g-w develop at 152bb45
<NOAA-EMC/global-workflow@152bb45>
.
I'm thinking that I need to update my copy of g-w to your
DavidNew-NOAA:feature/jcb-obsbias from g-w PR #2992
<NOAA-EMC/global-workflow#2992>. I wanted to run
this by you before updating and rebuilding.
—
Reply to this email directly, view it on GitHub
<#1355 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAAUIHG26UJRLHY6YLPUJS3Z7DJHFAVCNFSM6AAAAABQ4NMHIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJXGMZTIMBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Will keep this PR in draft mode until GDASApp and jcb-gdas yamls and templates work with updated JEDI hashes. |
This PR updates JEDI hashes in
sorc/
to bring in changes associated with the Model Variable Renaming Sprint. This is required to fully resolve #1313.Resolves #1313
Resolves #1362