Add a depth dependent e-fold scale #1494
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
requested review from
shlyaeva,
AndrewEichmann-NOAA and
JohnSteffen-NOAA
|
I don't think this PR works without the changes in NOAA-EMC/global-workflow#3238 . Keeping as draft for now. |
shlyaeva
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Didn't test, but looks reasonable to me. A couple comments/questions below.
With this change the vertical e-folding scale stays 500 (or vertical e-folding scale) where depth>1500m (or vertical e-folding scale * min efold depth ratio), and switches to depth/3 (depth/min efold depth ratio) otherwise (perhaps except for very shallow water where depth is below min depth), did I read it correct?
Open
22 tasks
JohnSteffen-NOAA
previously approved these changes
Feb 13, 2025
shlyaeva
previously approved these changes
Feb 14, 2025
guillaumevernieres
dismissed stale reviews from shlyaeva and JohnSteffen-NOAA
via
c3f452a
shlyaeva
approved these changes
Feb 14, 2025
JohnSteffen-NOAA
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not making use of the ensemble spread requires adding a few bells and whistles to the parametric B. This PR allows better control of the variance partitioning in shallow places, scaling e-fold to the local depth.
Draft PR until NOAA-EMC/global-workflow#3238 is merged
Companion PRs
Issues
Automated CI tests to run in Global Workflow