Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to inflate the ensemble while recentering #1501

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shlyaeva
Copy link
Collaborator

@shlyaeva shlyaeva commented Feb 14, 2025

Description

Adds code to the ensemble recentering to optionally inflate/deflate the ensemble variance by either a scalar (same for all variables) or a field from the file (has to be specified for all variables).

This is not exercised yet, since we don't know the parameters of inflation/deflation yet, but I tested with both options to check whether it behaves as expected.

Note: in the future refactoring we should switch to oops::Inflation that provides several different inflation options.

Issues

Related to #1496 (doesn't fix yet since we need to decide what parameters to use this with)

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shlyaeva

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ... as I learn C++

@RussTreadon-NOAA RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Feb 14, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Feb 14, 2025
@emcbot
Copy link

emcbot commented Feb 14, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Fri Feb 14 18:58:07 UTC 2025 on hfe08
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Feb 14 19:42:23 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_3DVarAOWCDA|C96C48_hybatmDA
Tests:                                  *Failed*
Tests: Failed at Fri Feb 14 20:02:06 UTC 2025
Tests: 85% tests passed, 7 tests failed out of 46
	2054 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlletkf_202103250000 (Failed)
	2055 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marinebmat_202103250000 (Failed)
	2056 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlinit_202103250000 (Failed)
	2057 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlvar_202103250000 (Failed)
	2058 - test_gdasapp_C48mx500_hybAOWCDA_gdas_ocnanalecen_202103250000 (Failed)
	2059 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2060 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1501/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 14, 2025
@RussTreadon-NOAA
Copy link
Contributor

CI built this PR inside g-w develop. I forgot that g-w PR #3238 remains in review and has not yet been merged into g-w develop. I think GDASApp based g-w CI for marine DA is broken until g-w PR #3238 is merged into g-w develop.

Is this your understanding @guillaumevernieres ?

@guillaumevernieres
Copy link
Contributor

CI built this PR inside g-w develop. I forgot that g-w PR #3238 remains in review and has not yet been merged into g-w develop. I think GDASApp based g-w CI for marine DA is broken until g-w PR #3238 is merged into g-w develop.

Is this your understanding @guillaumevernieres ?

Correct @RussTreadon-NOAA . We need to wait for #3238 ... I keep forgetting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants