-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to inflate the ensemble while recentering #1501
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shlyaeva
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ... as I learn C++
Automated GW-GDASApp Testing Results:
|
CI built this PR inside g-w Is this your understanding @guillaumevernieres ? |
Correct @RussTreadon-NOAA . We need to wait for #3238 ... I keep forgetting. |
Description
Adds code to the ensemble recentering to optionally inflate/deflate the ensemble variance by either a scalar (same for all variables) or a field from the file (has to be specified for all variables).
This is not exercised yet, since we don't know the parameters of inflation/deflation yet, but I tested with both options to check whether it behaves as expected.
Note: in the future refactoring we should switch to oops::Inflation that provides several different inflation options.
Issues
Related to #1496 (doesn't fix yet since we need to decide what parameters to use this with)
Automated CI tests to run in Global Workflow