Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial changes for vrfy refactoring #532

Merged
merged 5 commits into from
Jul 17, 2023
Merged

initial changes for vrfy refactoring #532

merged 5 commits into from
Jul 17, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Basic changes to address #531 - subroutine defs offloaded into imported module

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Jul 13, 2023
@emcbot emcbot added hera-RT-Running Automated testing running on Hera orion-RT-Running Automated testing running on Orion and removed hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Jul 13, 2023
@emcbot
Copy link

emcbot commented Jul 13, 2023

Automated GDASApp Testing Results:
Machine: hera

Start: Thu Jul 13 21:00:22 UTC 2023 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jul 13 21:48:09 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jul 13 21:49:16 UTC 2023
Tests: 96% tests passed, 1 tests failed out of 28
	1459 - test_gdasapp_check_python_norms (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/PR/532/GDASApp/build/log.ctest

@emcbot emcbot added hera-RT-Failed Automated testing failed on Hera and removed hera-RT-Running Automated testing running on Hera labels Jul 13, 2023
@emcbot
Copy link

emcbot commented Jul 13, 2023

Automated GDASApp Testing Results:
Machine: orion

Start: Thu Jul 13 16:00:44 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jul 13 16:50:47 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jul 13 16:53:11 CDT 2023
Tests: 57% tests passed, 12 tests failed out of 28
	1459 - test_gdasapp_check_python_norms (Failed)
	1469 - test_gdasapp_convert_bufr_temp_dbuoy (Failed)
	1470 - test_gdasapp_convert_bufr_salt_dbuoy (Failed)
	1471 - test_gdasapp_convert_bufr_temp_mbuoyb (Failed)
	1472 - test_gdasapp_convert_bufr_salt_mbuoyb (Failed)
	1473 - test_gdasapp_convert_bufr_tesacprof (Failed)
	1474 - test_gdasapp_convert_bufr_trkobprof (Failed)
	1475 - test_gdasapp_convert_bufr_sfcships (Failed)
	1476 - test_gdasapp_convert_bufr_sfcshipsu (Failed)
	1480 - test_gdasapp_land_imsproc (Failed)
	1482 - test_gdasapp_land_letkfoi_snowda (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/PR/532/GDASApp/build/log.ctest

@emcbot emcbot added orion-RT-Failed Automated testing failed on Orion and removed orion-RT-Running Automated testing running on Orion labels Jul 13, 2023
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed orion-RT-Failed Automated testing failed on Orion hera-RT-Failed Automated testing failed on Hera labels Jul 14, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jul 14, 2023
@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Jul 14 14:05:08 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Jul 14 15:08:04 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Jul 14 15:21:55 UTC 2023
Tests: 98% tests passed, 1 tests failed out of 49
	1459 - test_gdasapp_check_python_norms (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/532/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 14, 2023
@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Jul 14 09:02:24 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Jul 14 10:29:41 CDT 2023
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/532/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jul 14, 2023
guillaumevernieres
guillaumevernieres requested changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your python norm @AndrewEichmann-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Jul 17, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jul 17, 2023
@emcbot
Copy link

emcbot commented Jul 17, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jul 17 14:45:48 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 17 15:33:37 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Jul 17 15:44:21 UTC 2023
Tests: 92% tests passed, 4 tests failed out of 50
	1515 - test_gdasapp_atm_jjob_var_run (Failed)
	1516 - test_gdasapp_atm_jjob_var_final (Failed)
	1518 - test_gdasapp_atm_jjob_ens_run (Failed)
	1519 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/532/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 17, 2023
@emcbot
Copy link

emcbot commented Jul 17, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Jul 17 09:46:59 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 17 10:47:18 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Jul 17 11:04:52 CDT 2023
Tests: 92% tests passed, 4 tests failed out of 50
	1515 - test_gdasapp_atm_jjob_var_run (Failed)
	1516 - test_gdasapp_atm_jjob_var_final (Failed)
	1518 - test_gdasapp_atm_jjob_ens_run (Failed)
	1519 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/532/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jul 17, 2023
guillaumevernieres
guillaumevernieres approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA . I'm going to merge this since the ci failure is unrelated to this PR.

@guillaumevernieres guillaumevernieres merged commit a184e68 into develop Jul 17, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewEichmann-NOAA @emcbot @guillaumevernieres