Refactoring of vrfy - transferred bulk of plotting to sub-script

[AndrewEichmann-NOAA]

No functional changes, just moved plotting-specific code from vrfy script to script in ush. Also cleaned up some superfluous variables.

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jul 17 21:18:30 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 17 22:26:19 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jul 17 22:47:59 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 53

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Jul 17 16:17:47 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 17 17:32:22 CDT 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jul 17 17:55:26 CDT 2023
Tests: 100% tests passed, 0 tests failed out of 53

[guillaumevernieres]

Still a bit of a mess ... Which I created!

1 - For the state figures, we have 4 cases that are generating similar figures, the difference being the bounds, and input files ...

Instead of splitting into plot_analysis and plot_increment, split into:

• plot_increment
• plot_background
• plot_analysis
• plot_bkgerr

Ideally, we should create a simple ViewState class that would look something like this:

class ViewState:
    def __init__(self, config_dict):
        self.config = config_dict
        self.stuff = config_dict['stuff']
        ...
        # Where config contains the bounds, filename and whatever else is needed to plot stuff

    def plot(self):
        # Loop over variables, slices (horiz and vertical) and projections ... and whatever else is needed

Now instead of having 4 separate function, you have one class that you "instantiate" 4 times with different configurations. In the ex global script, you'd do something like this:

config= ...
viewIncr = ViewState(config)
viewIncr.plot()

config= ...
viewBkg = ViewState(config)
viewBkg.plot()

config= ...
viewAna = ViewState(config)
viewAna.plot()

config= ...
viewBkgErr = ViewState(config)
viewBkgErr.plot()

That should remove quite a bit of code and make things a bit more readable.
Hope that makes sense, happy to chat if not.

2 - Move the soca_vrfy.py into ush/soca

[AndrewEichmann-NOAA]

@guillaumevernieres This is a minor thing, but should ush/diag_statistics.py go into soca as well? It's run only from our vrfy task

[guillaumevernieres]

@guillaumevernieres This is a minor thing, but should ush/diag_statistics.py go into soca as well? It's run only from our vrfy task

If we're the only one using it, I would say yes.

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Jul 27 14:02:30 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jul 27 15:34:03 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jul 27 16:14:29 CDT 2023
Tests: 98% tests passed, 1 tests failed out of 53
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/538/global-workflow/sorc/gdas.cd/build/log.ctest

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jul 27 19:06:04 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jul 27 20:10:56 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jul 27 21:28:17 UTC 2023
Tests: 94% tests passed, 3 tests failed out of 53
	1535 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/538/global-workflow/sorc/gdas.cd/build/log.ctest

[guillaumevernieres]

Thanks for doing this @AndrewEichmann-NOAA . Looks good. Just one comment related to variable naming convention.

[AndrewEichmann-NOAA]

Now python coding style is failing on ush/ufsda/genYAML.py, which I don't touch

[guillaumevernieres]

Now python coding style is failing on ush/ufsda/genYAML.py, which I don't touch

It looks like it's a simple fix @AndrewEichmann-NOAA . Maybe pycodestyle was recently updated. Can you try what's suggested, replace == with is L34 of genYAML.py

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Aug  3 14:04:56 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug  3 15:05:29 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Aug  3 15:19:24 UTC 2023
Tests: 91% tests passed, 5 tests failed out of 53
	1587 - test_gdasapp_atm_jjob_var_run (Failed)
	1588 - test_gdasapp_atm_jjob_var_final (Failed)
	1590 - test_gdasapp_atm_jjob_ens_run (Failed)
	1591 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/538/global-workflow/sorc/gdas.cd/build/log.ctest

[AndrewEichmann-NOAA]

@guillaumevernieres This currently passes soca ctests on Hera

[guillaumevernieres]

👍