Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a C++ linter #555

Merged
merged 26 commits into from
Aug 10, 2023
Merged

Add in a C++ linter #555

merged 26 commits into from
Aug 10, 2023

Conversation

CoryMartin-NOAA
Copy link
Contributor

@guillaumevernieres hates lint! So let's clean this place up a bit and keep it tidy! We already do this for python, extending it to C++ for the utilities directory.

@CoryMartin-NOAA
Copy link
Contributor Author

The irony that the C++ linter script fails the python norms!

@emcbot
Copy link

emcbot commented Aug 9, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Aug  9 15:34:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Aug  9 16:54:11 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Aug  9 17:43:19 CDT 2023
Tests: 89% tests passed, 6 tests failed out of 55
	1232 - test_gdasapp_util_coding_norms (Failed)
	1596 - test_gdasapp_atm_jjob_var_run (Failed)
	1597 - test_gdasapp_atm_jjob_var_final (Failed)
	1599 - test_gdasapp_atm_jjob_ens_run (Failed)
	1600 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/555/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Aug 9, 2023
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Aug 10, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Aug 10, 2023
@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Aug 10 13:18:40 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug 10 14:30:16 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Aug 10 14:52:16 UTC 2023
Tests: 89% tests passed, 6 tests failed out of 55
	1232 - test_gdasapp_util_coding_norms (Failed)
	1596 - test_gdasapp_atm_jjob_var_run (Failed)
	1597 - test_gdasapp_atm_jjob_var_final (Failed)
	1599 - test_gdasapp_atm_jjob_ens_run (Failed)
	1600 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/555/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Aug 10, 2023
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Aug 10, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Aug 10, 2023
AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I wonder what lessons are in store from this....

@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Aug 10 08:17:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug 10 09:31:29 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Aug 10 10:43:10 CDT 2023
Tests: 89% tests passed, 6 tests failed out of 55
	1232 - test_gdasapp_util_coding_norms (Failed)
	1596 - test_gdasapp_atm_jjob_var_run (Failed)
	1597 - test_gdasapp_atm_jjob_var_final (Failed)
	1599 - test_gdasapp_atm_jjob_ens_run (Failed)
	1600 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/555/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Aug 10, 2023
@CoryMartin-NOAA CoryMartin-NOAA removed the orion-GW-RT-Failed Automated testing with global-workflow failed on Orion label Aug 10, 2023
@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Aug 10 15:05:19 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug 10 16:14:17 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Aug 10 16:50:34 UTC 2023
Tests: 91% tests passed, 5 tests failed out of 55
	1596 - test_gdasapp_atm_jjob_var_run (Failed)
	1597 - test_gdasapp_atm_jjob_var_final (Failed)
	1599 - test_gdasapp_atm_jjob_ens_run (Failed)
	1600 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/555/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Aug 10, 2023
@CoryMartin-NOAA CoryMartin-NOAA merged commit da20263 into develop Aug 10, 2023
13 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/cpplint branch August 10, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres left review comments

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

@ADCollard ADCollard Awaiting requested review from ADCollard

@DavidNew-NOAA DavidNew-NOAA Awaiting requested review from DavidNew-NOAA

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CoryMartin-NOAA @guillaumevernieres @emcbot @AndrewEichmann-NOAA