Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the capability to assimilate the MADIS snow depth for global-workflow #602

Merged
merged 81 commits into from
Sep 12, 2023

Conversation

jiaruidong2017
Copy link
Collaborator

@jiaruidong2017 jiaruidong2017 commented Sep 5, 2023

This PR adds bufr_snocvr.yaml to covert GTS based madis snow depth data into IODA format and adds snocvr_snow.yaml to enable the global-workflow to assimilate the madis snow depth data from GTS.

This PR also updates the configures gdas_land_gts_only.yaml and gdas_land_prototype.yaml to include the new madis snow depth data for global-workflow.

This PR contributes to the NOAA-EMC/global-workflow#1836 for assimilating the MADIS snow depth.

@jiaruidong2017 jiaruidong2017 added the hera-RT Queue for automated testing on Hera label Sep 9, 2023
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Sep 9, 2023
@emcbot
Copy link

emcbot commented Sep 9, 2023

Automated GDASApp Testing Results:
Machine: hera

Start: Sat Sep  9 23:15:22 UTC 2023 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Sep  9 23:55:50 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Sat Sep  9 23:57:10 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 25

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Sep 9, 2023
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
I have one suggestion -- we have been trying to move away from the $( ) syntax in yaml and replace it with {{ }}. It is still necessary to have the ${ } syntax, especially when including nested yamls. Would you be able and willing to replace $( ) with {{ }} in this PR?

parm/land/obs/config/snocvr_snow.yaml Outdated Show resolved Hide resolved
test/testinput/bufr_snocvr_snow.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jiaruidong2017
Copy link
Collaborator Author

@aerorahul Thanks for quick reviews.

@jiaruidong2017 jiaruidong2017 added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-RT-Passed Automated testing successful on Hera labels Sep 12, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Sep 12, 2023
@emcbot
Copy link

emcbot commented Sep 12, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Sep 12 19:06:30 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Sep 12 20:12:44 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Sep 12 20:45:25 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 49

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 12, 2023
@CoryMartin-NOAA CoryMartin-NOAA merged commit 2ed98b2 into develop Sep 12, 2023
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/madis_da branch September 12, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants