-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the capability to assimilate the MADIS snow depth for global-workflow #602
Conversation
Automated GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
I have one suggestion -- we have been trying to move away from the $( )
syntax in yaml and replace it with {{ }}
. It is still necessary to have the ${ }
syntax, especially when including nested yamls. Would you be able and willing to replace $( )
with {{ }}
in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@aerorahul Thanks for quick reviews. |
Automated Global-Workflow GDASApp Testing Results:
|
This PR adds
bufr_snocvr.yaml
to covert GTS basedmadis
snow depth data into IODA format and addssnocvr_snow.yaml
to enable the global-workflow to assimilate the madis snow depth data from GTS.This PR also updates the configures
gdas_land_gts_only.yaml
andgdas_land_prototype.yaml
to include the newmadis
snow depth data for global-workflow.This PR contributes to the NOAA-EMC/global-workflow#1836 for assimilating the MADIS snow depth.