Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ocean obs prep script and module #635

Merged
merged 25 commits into from
Sep 22, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Addresses #618

Also fixes two AMSR2 sea ice yamls

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA . A few minor comments. It seems fine to me but I have not tested.

scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
ush/soca/prep_marine_obs.py Outdated Show resolved Hide resolved
ush/soca/prep_marine_obs.py Show resolved Hide resolved
ush/soca/obs_list_test.yaml Show resolved Hide resolved
ush/soca/prep_marine_obs.py Outdated Show resolved Hide resolved
ush/soca/prep_marine_obs.py Outdated Show resolved Hide resolved
ush/soca/obs_list_test.yaml Outdated Show resolved Hide resolved
ush/soca/obs_list_test.yaml Outdated Show resolved Hide resolved
ush/soca/obs_list_test.yaml Outdated Show resolved Hide resolved
ush/soca/obs_list_test.yaml Outdated Show resolved Hide resolved
ush/soca/obs_list_test.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AndrewEichmann-NOAA .
Thanks for doing this.

@guillaumevernieres guillaumevernieres merged commit bd5cb2e into develop Sep 22, 2023
5 checks passed
@guillaumevernieres
Copy link
Contributor

Thanks @AndrewEichmann-NOAA

@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/prepocniodaobs branch November 17, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants