Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a list of files to the marine obs converter #638

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

guillaumevernieres
Copy link
Contributor

Description

This PR adds the possibility to process more than one file.

provider: RADS
window begin: 2018-04-15T06:00:00Z
window end: 2018-04-15T12:00:00Z
variable: absoluteDynamicTopography
output file: rads_adt_j3_2021182.ioda.nc
input files:
- rads_adt_j3_2021182.nc4
- rads_adt_j3_2021182.nc4

The 2 RADS obs files in the input files list are read in parallel, concatenated and written in the output file rads_adt_j3_2021182.ioda.nc.
Currently the code requires as many PE's as there are input files, not great, something that I might change later.

apchoiCMD
apchoiCMD previously approved these changes Sep 25, 2023
ShastriPaturi
ShastriPaturi previously approved these changes Sep 25, 2023
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume we'll be testing this the coming week

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 25, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Sep 25, 2023
@emcbot
Copy link

emcbot commented Sep 25, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Sep 25 09:02:50 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Sep 25 10:17:34 CDT 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Sep 25 10:47:33 CDT 2023
Tests: 100% tests passed, 0 tests failed out of 53

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Sep 25, 2023
@emcbot
Copy link

emcbot commented Sep 25, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Sep 25 14:05:04 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Sep 25 15:15:22 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Sep 25 16:16:33 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 53

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 25, 2023
utils/obsproc/NetCDFToIodaConverter.h Outdated Show resolved Hide resolved
utils/obsproc/NetCDFToIodaConverter.h Outdated Show resolved Hide resolved
utils/obsproc/NetCDFToIodaConverter.h Outdated Show resolved Hide resolved
utils/obsproc/NetCDFToIodaConverter.h Show resolved Hide resolved
utils/obsproc/NetCDFToIodaConverter.h Outdated Show resolved Hide resolved
utils/obsproc/NetCDFToIodaConverter.h Show resolved Hide resolved
Copy link
Collaborator

@rmclaren rmclaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes are up to you.

@guillaumevernieres guillaumevernieres merged commit b4508a5 into develop Sep 25, 2023
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/iodaconv-mpi branch September 25, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants