Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adt data sets are added for obs prep #641

Merged
merged 4 commits into from
Sep 25, 2023
Merged

adt data sets are added for obs prep #641

merged 4 commits into from
Sep 25, 2023

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Sep 25, 2023 •
edited
Loading

lists of rad sets to the test

@guillaumevernieres
Copy link
Contributor

@apchoiCMD :

  1. You did not have to close the previous PR
  2. Choose a title that describe the work that you want to commit to develop. fixed conflict file merging from team members does not describe your work.

@apchoiCMD apchoiCMD changed the title fixed conflict file merging from team members adt data sets are added Sep 25, 2023
@apchoiCMD apchoiCMD changed the title adt data sets are added adt data sets are added for obs prep Sep 25, 2023
guillaumevernieres
guillaumevernieres requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. I think 2 .cdl files are probably enough ... Sorry again!

utils/test/prepdata.sh Outdated Show resolved Hide resolved
guillaumevernieres
guillaumevernieres approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks @apchoiCMD .

@guillaumevernieres guillaumevernieres merged commit 2799645 into develop Sep 25, 2023
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/adt_rad branch September 25, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apchoiCMD @guillaumevernieres