Updates to run gw ctests using feature/submodule #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hera ctests Orion ctests |
|
test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY failure test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY failed for the same reason on Hera and Orion. The initial failure is due to This is puzzling since ctest submits test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY via Resubmit. Ran further but still failed as follows (log from Hera) Stop investigation here since we may need updates to |
RussTreadon-NOAA
added
hera-GW-RT
emcbot
added
orion-GW-RT-Running
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Failed
|
orion-GW-RT-running The automated Orion global-workflow test is still marked as running. A check of
This is odd. The same script is executed on Hera where the GW-RT clone, build, and execute ran. |
|
@CoryMartin-NOAA and @guillaumevernieres , what is the role of the Using Hera as the example, we wind up with
test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP example When this test executes In this failure variable If the script runs to completion.
test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY example As mentioned above, the test initially fails because an eva module is not found What's odd is that If What's a good solution to the above issues? |
|
@RussTreadon-NOAA the role of I think those My guess is that the Is putting everything in |
I think it's worth the effort @CoryMartin-NOAA . If the only issue is the ocean verify test, we can commented out for now and fix it later. I'll try to find some time to look into it today, but we've got an other blocking issue that I need to fix first. |
|
Is placing jedi repos in If we want to stick with submodules in |
|
My main concern (perhaps it is being too OCD) is that the root directory of GDASApp then becomes littered with 10+ submodules instead of just a few subdirectories like sorc/ ush/ test/ I think there are probably a few cmake tricks we just need to learn to make this whole process easier. But I just need to figure out which breadcrumb to follow first. |
|
I prefer the cleaner look of Is there a way to define HOMEgfs in The ATM gw ctests set HOMEgfs at script level via Might Rahul have useful cmake insights for this and other questions we have? |
|
I think we want (maybe?) |
|
Added prints to cmake. For my Hera installation Using |
RussTreadon-NOAA
added
orion-GW-RT
emcbot
added
orion-GW-RT-Running
|
Looking more closely at this, the EVA test will fail because the EVA version is updated but the YAML for this ctest was not updated. @guillaumevernieres suggested yesterday to comment out this ctest and it would get fixed at a later date. |
CoryMartin-NOAA
removed
the
orion-GW-RT-Running
Closed
|
I'm fine with punting the test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY fix to a new PR. That said, do we know
If we know the answer to these questions, I can make the eva yaml(s) updates in this PR. |
|
it might be as simple as adding the following: to the graphics section of the YAML, see: https://github.com/JCSDA-internal/eva/pull/158/files |
|
Great advice @CoryMartin-NOAA. I simply added to Any suggestions @guillaumevernieres or @AndrewEichmann-NOAA ? The above is copied from |
My suggestion is to comment out and ignore for now @RussTreadon-NOAA . We're all tied up doing other things right now but we should be able to get to it before the end of the week. Thanks for trying though! |
guillaumevernieres
approved these changes
Jan 4, 2024
@emilyhcliu found that permission restrictions on `bufr2ioda_subpfl_argo_profiles.py` prevent it from being executed. [`feature/chmod`](https://github.com/NOAA-EMC/GDASApp/tree/feature/chmod) was created and the file permissions changed so that `bufr2ioda_subpfl_argo_profiles.py` is executable. Fixes NOAA-EMC#788
- The UFO filters are rearranged by using the explicit filter ordering with `obs pre filters`, `obs prior filters` and `obs post filters` options. - Add `Temporal Thinning filter` into the `obs post filters` section and and arrange it after the `Background Check filter` and before the `Buddy check filter`. - Rename the IMS IODA file name and copy it into the `rundir/obs` directory for the late use in the snow analysis in the global workflow (NOAA-EMC/global-workflow#2033). Co-authored-by: Cory Martin <[email protected]>
This PR is prepared for NOAA-EMC/global-workflow#2199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two updates:
developata34773aintofeature/submodulefeature/submoduleso that gw ctests run to completion.One gw ctest, test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY, still fails after the changes in 2.