-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUFR2IODA python API converters for marine monthly in situ BUFR #844
BUFR2IODA python API converters for marine monthly in situ BUFR #844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ShastriPaturi !
1 - Your choice , but I thought @rmclaren said we could use yaml
instead of jason
.
2 - I'm not reviewing the code, but it looks like you're having "extra space" issues with your text editor.
3 - code norm's failing
Are these converters tested as part of the ci?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major issues besides int32 vs int64 for sequenceNumber, though there are some things to consider/recommendations that I have.
I agree and addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Looks good!
Thanks a lot @nicholasesposito. Appreciate your quick response. |
This PR adds bufr2ioda python API converters for marine monthly in situ data based on the work done during the "End-to-End Code Sprint" by the atmosphere group.
partially resolves #711