Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUFR2IODA python API converters for marine monthly in situ BUFR #844

Merged
merged 12 commits into from
Jan 18, 2024

Conversation

ShastriPaturi
Copy link
Collaborator

@ShastriPaturi ShastriPaturi commented Jan 10, 2024

This PR adds bufr2ioda python API converters for marine monthly in situ data based on the work done during the "End-to-End Code Sprint" by the atmosphere group.

partially resolves #711

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShastriPaturi !
1 - Your choice , but I thought @rmclaren said we could use yaml instead of jason.
2 - I'm not reviewing the code, but it looks like you're having "extra space" issues with your text editor.
3 - code norm's failing
Are these converters tested as part of the ci?

@ShastriPaturi
Copy link
Collaborator Author

Thanks @ShastriPaturi ! 1 - Your choice , but I thought @rmclaren said we could use yaml instead of jason. 2 - I'm not reviewing the code, but it looks like you're having "extra space" issues with your text editor. 3 - code norm's failing Are these converters tested as part of the ci?
1 - Your choice , but I thought @rmclaren said we could use yaml instead of jason
Following what was done in the [End-to-End] Code sprint
2 - I'm not reviewing the code, but it looks like you're having "extra space" issues with your text editor.
fixing
3 - code norm's failing
fixing
Are these converters tested as part of the ci?
Not that I know of

Copy link
Collaborator

@nicholasesposito nicholasesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues besides int32 vs int64 for sequenceNumber, though there are some things to consider/recommendations that I have.

ush/ioda/bufr2ioda/bufr2ioda_bathythermal_profiles.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/bufr2ioda_subpfl_argo_profiles.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/bufr2ioda_tesac_mammals_profiles.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/bufr2ioda_tesac_mammals_profiles.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/bufr2ioda_tesac_mammals_profiles.py Outdated Show resolved Hide resolved
ush/ioda/bufr2ioda/bufr2ioda_altkob_surface.py Outdated Show resolved Hide resolved
@ShastriPaturi
Copy link
Collaborator Author

No major issues besides int32 vs int64 for sequenceNumber, though there are some things to consider/recommendations that I have.

I agree and addressed.

Copy link
Collaborator

@nicholasesposito nicholasesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Looks good!

@ShastriPaturi
Copy link
Collaborator Author

Thanks for making the changes. Looks good!

Thanks a lot @nicholasesposito. Appreciate your quick response.

@guillaumevernieres guillaumevernieres merged commit 7f74f17 into develop Jan 18, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/marine-monthly-bufr2ioda branch March 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in situ BUFR IODA converters using BUFR2IODA python API
3 participants