Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update paths in soca scripts and tests #845

Merged
merged 1 commit into from
Jan 10, 2024
Merged

update paths in soca scripts and tests #845

merged 1 commit into from
Jan 10, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

Update soca paths to be consistent with use of submodules

@RussTreadon-NOAA
Copy link
Contributor Author

Given ctest results (non-gw and gw) reported in PR #811 , decide to bring the soca path changes into GDASApp feature/submodule. Once this is done,

  1. update submodule hashes in authoritative feature/submodule
  2. rerun and document gw ctest results
  3. get PR #811 merged into authoritative develop.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review January 10, 2024 21:33
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 10, 2024
@RussTreadon-NOAA RussTreadon-NOAA changed the title update paths in soca scripts and tests (#811) update paths in soca scripts and tests Jan 10, 2024
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Jan 10, 2024
Merged
@guillaumevernieres
Copy link
Contributor

Thanks @RussTreadon-NOAA !

@CoryMartin-NOAA CoryMartin-NOAA merged commit f19bdd9 into NOAA-EMC:feature/submodule Jan 10, 2024
2 checks passed
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you, @CoryMartin-NOAA . I'll get to work updating submodule hashes in the authoritative feature/submodule.

@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/submodule branch January 10, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RussTreadon-NOAA @guillaumevernieres @CoryMartin-NOAA