Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up of the "bye bye" R2D2 PR: More marine obs in the ctests #847

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Follow up of the "bye bye" R2D2 PR: More marine obs in the ctests #847

merged 6 commits into from
Jan 11, 2024

Conversation

guillaumevernieres
Copy link
Contributor

  • I moved all the untested obs yaml under obs/old, assuming that they probably are all wrong since the removal of R2D2
  • I added (fake) AMSR2 icec cdl files
  • Same as above but for ADT, also skipping the concatenation post ioda processing and concatenating with the new ioda converters
  • I've made an effort to try to use the provider's file naming convention, but do check.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jan 11, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 11, 2024
@emcbot
Copy link

emcbot commented Jan 11, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jan 11 02:03:19 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jan 11 02:14:49 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Thu Jan 11 02:14:51 UTC 2024
Tests:

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 11, 2024
ShastriPaturi
ShastriPaturi requested changes Jan 11, 2024
View reviewed changes
parm/soca/obsproc/obsproc_config.yaml Outdated Show resolved Hide resolved
test/soca/gw/prepdata.sh Outdated Show resolved Hide resolved
apchoiCMD
apchoiCMD previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, look good!

ShastriPaturi
ShastriPaturi previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@guillaumevernieres
Copy link
Contributor Author

@ShastriPaturi , @apchoiCMD , @AndrewEichmann-NOAA , I just adjusted the fake dates for the rads adt to fall within the DA window.

@guillaumevernieres guillaumevernieres merged commit 4e3e586 into develop Jan 11, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/more-obs branch March 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@ShastriPaturi ShastriPaturi Awaiting requested review from ShastriPaturi

@apchoiCMD apchoiCMD Awaiting requested review from apchoiCMD

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guillaumevernieres @emcbot @ShastriPaturi @AndrewEichmann-NOAA @apchoiCMD