Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using diffusion central block #851

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Using diffusion central block #851

merged 6 commits into from
Jan 17, 2024

Conversation

guillaumevernieres
Copy link
Contributor

We'll have to test and readjust the hybrid B weights, since the correlation central block is now normalized! (thanks @travissluka) , but the plumbing is mostly sorted out.

Issues not addressed yet

  • Better vertical decorrelation scales
  • The horizontal diffusion shouldn't be initialized at every cycle.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jan 11, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 11, 2024
@emcbot
Copy link

emcbot commented Jan 11, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Jan 11 22:48:55 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jan 11 23:00:57 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Thu Jan 11 23:01:00 UTC 2024
Tests:

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 11, 2024
@apchoiCMD
Copy link
Collaborator

We'll have to test and readjust the hybrid B weights, since the correlation central block is now normalized! (thanks @travissluka) , but the plumbing is mostly sorted out.

Issues not addressed yet

  • Better vertical decorrelation scales
  • The horizontal diffusion shouldn't be initialized at every cycle.

@apchoiCMD apchoiCMD closed this Jan 17, 2024
@apchoiCMD apchoiCMD reopened this Jan 17, 2024
@guillaumevernieres guillaumevernieres merged commit 0e97461 into develop Jan 17, 2024
7 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/diffusion branch March 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travissluka travissluka travissluka left review comments

@apchoiCMD apchoiCMD apchoiCMD approved these changes

@ShastriPaturi ShastriPaturi ShastriPaturi approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to 2D/1D diffusion
5 participants
@guillaumevernieres @emcbot @apchoiCMD @travissluka @ShastriPaturi